Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): use correct update function #460

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Oct 21, 2021

fixes an issue where a failure to load deployments would update the error state of builds instead of deployments causing a error message on the builds tab before the automatic refresh loads in the builds correctly.

also limits loading to when you are on the deployments tab.

@wass3r wass3r self-assigned this Oct 21, 2021
@wass3r wass3r added the bug Indicates a bug label Oct 21, 2021
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT! one thing, my previous "fix" was incorrect, I think I "fixed" the singular deployment response but you found the correct one:

( { model | repo = updateDeployments (toFailure error) rm }, addError error )

I propose we squash my previous "addFailure" and just offset this to the notification tray

                    ( model, addError error )

@wass3r wass3r marked this pull request as ready for review October 21, 2021 14:18
@wass3r wass3r requested a review from a team as a code owner October 21, 2021 14:18
@wass3r wass3r merged commit 9ef6468 into master Oct 21, 2021
@wass3r wass3r deleted the fix/deployment-load branch October 21, 2021 15:29
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
* fix(deployment): use correct update function

* tweak based on feedback
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
* fix(deployment): use correct update function

* tweak based on feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants