Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(make): change order of clean cmds #60

Merged
merged 1 commit into from
Dec 20, 2019
Merged

build(make): change order of clean cmds #60

merged 1 commit into from
Dec 20, 2019

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Dec 20, 2019

prior to this we deleted node_modules first and then ran an npm script that executes something that resides in one of the deleted folders 🐛

@wass3r wass3r requested a review from a team as a code owner December 20, 2019 16:41
jbrockopp
jbrockopp approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meinenec meinenec merged commit c05cc83 into master Dec 20, 2019
@meinenec meinenec deleted the hotfix/make branch December 20, 2019 20:56
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
@wass3r
build(make): change order of clean cmds (#60)
aa5f734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meinenec meinenec meinenec approved these changes

@jbrockopp jbrockopp jbrockopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wass3r @jbrockopp @meinenec @wass3rw3rk