fix: referencing symbolic links with tar archive #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockopp
added
bug
|
Why not just use |
|
@JordanSussman essentially they are functionally equivalent 🤷 I think each way has it's own pros/cons but none of us on our side really care so we'll update it 👍 |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 11.21% 11.21%
=======================================
Files 6 6
Lines 419 419
=======================================
Hits 47 47
Misses 369 369
Partials 3 3 |
wass3r
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to resolve go-vela/community#30
Currently, there is a known bug in the library we use to create the archives we upload to the cache:
mholt/archiver#202
A PR exists to resolve this bug but the maintainers were unwilling to merge until adequate tests have been written:
mholt/archiver#201
In an attempt to fix the issue, we've forked the upstream repo to this org:
https://github.com/go-vela/archiver
And have made the changes reflected in the PR to see if it resolves the underlying issue:
mholt/archiver@master...go-vela:master