Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Over abstraction #7

Open
lil5 opened this issue Sep 21, 2024 · 0 comments
Open

Over abstraction #7

lil5 opened this issue Sep 21, 2024 · 0 comments

Comments

@lil5
Copy link

lil5 commented Sep 21, 2024

Assuming this is an example for others to quickly learn from, the abstractions built here only make it harder to understand.

  • Response json is hidden behind 2-3 layers.
  • Storage actions are hidden and it's not clear which storage is used at quick glance.
  • JavaScript is written in a highly abstract manner, it would be easier if the steps are numbered and run from separate functions & again too much abstraction for learning purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lil5