From 9322e17a1c699c927eacb2d48633f95212dca031 Mon Sep 17 00:00:00 2001 From: James Elliott Date: Mon, 2 Oct 2023 12:18:19 +1100 Subject: [PATCH] build: add go 1.21 (#167) --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 ++ .github/workflows/go.yml | 1 + .renovaterc | 2 +- README.md | 18 ++++++++++++++++++ go.mod | 2 +- 5 files changed, 23 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 1cb5f59..ccb02ea 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -18,6 +18,8 @@ body: description: What version of the library are you using or which versions do you see the issue in? multiple: true options: + - 0.8.6 + - 0.8.5 - 0.8.4 - 0.8.3 - 0.8.2 diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index d83e041..ad5464b 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -10,6 +10,7 @@ jobs: - '1.18' - '1.19' - '1.20' + - '1.21' fail-fast: false steps: - name: Set up Go ${{ matrix.go }} diff --git a/.renovaterc b/.renovaterc index 22f51a5..63d3aeb 100644 --- a/.renovaterc +++ b/.renovaterc @@ -1,7 +1,7 @@ { "$schema": "https://docs.renovatebot.com/renovate-schema.json", "constraints": { - "go": "1.20" + "go": "1.21" }, "extends": [ "config:base", diff --git a/README.md b/README.md index 2a8551e..f0a7c28 100644 --- a/README.md +++ b/README.md @@ -18,6 +18,24 @@ libraries. It is distributed under the same 3-Clause BSD license as the original fork, with the only amendment being the additional 3-Clause BSD license attributing license rights to this repository. +## Go Version Support Policy + +This library will officially support versions of go which are currently supported by the go maintainers (usually 3 +minor versions) with a brief transition time (usually 1 patch release of go, for example if go 1.21.0 is released, we +will likely still support go 1.17 until go 1.21.1 is released). + +This library in our opinion handles a critical element of security in a dependent project and we aim to avoid backwards +compatability at the cost of security wherever possible. We also consider this especially important in a language like +go where their backwards compatibility when upgrading the compile tools is usually flawless. + +This policy means that users who wish to build this with older versions of go may find there are features being used +which are not available in that version. The current intentionally supported versions of go are as follows: + +- go 1.21 +- go 1.20 +- go 1.19 +- go 1.18 + ## Status This library is still version 0, as per Semantic Versioning 2.0 rules there may be breaking changes without warning. diff --git a/go.mod b/go.mod index 11e3ddc..8766ebe 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/go-webauthn/webauthn -go 1.20 +go 1.21 require ( github.com/fxamacker/cbor/v2 v2.4.0