-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support hints and attestation formats #216
Conversation
6bb1cb7
to
1b8248d
Compare
This adds support to the hints and attestation format options, both of which are new elements from Level 3 which are effectively optional. This allows users who wish to leverage this option to do so with no negative effects for those who do not.
1b8248d
to
3ed1f0d
Compare
WalkthroughThe changes primarily focus on refactoring the attestation format registration across various modules in a WebAuthn implementation, replacing string literals with enums to enhance type safety and maintainability. Additionally, new fields and functions are introduced to support hints and attestation format preferences in credential options. Changes
Assessment against linked issues
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (10)
Additional comments not posted (23)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@james-d-elliott when do you think you'll cut a new release with this PR? |
Likely after the final breaking change for the next release which is #239 which is almost done, I'm just testing it and making minor adjustments. |
This adds support to the hints and attestation format options, both of which are new elements from Level 3 which are effectively optional. This allows users who wish to leverage this option to do so with no negative effects for those who do not.
Closes #208
Summary by CodeRabbit
New Features
Refactor
Documentation
Deprecations