Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml 1.1 bool string values should be quoted #489

Closed
laverya opened this issue Jul 22, 2019 · 1 comment
Closed

Yaml 1.1 bool string values should be quoted #489

laverya opened this issue Jul 22, 2019 · 1 comment

Comments

@laverya
Copy link
Contributor

laverya commented Jul 22, 2019

When encoding a string like yes or Y or On, we should include quotes to preserve compatibility with the yaml 1.1 spec. This can lead to bugs where the generated yaml is incompatible with tools like kustomize, as discovered in this ship issue replicatedhq/ship#1035.
@laverya laverya mentioned this issue Jul 22, 2019
Closed
@laverya laverya mentioned this issue Mar 20, 2020
Merged
@laverya
Copy link
Contributor Author

laverya commented Mar 20, 2020

Resolved by #583.

@laverya laverya closed this as completed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laverya