-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sopssecretgenerator can't decrypt files encrypted with sops v3.6.0 #12
Comments
I generated some encrypted files using different sops versions, and I found the following: sops v3.4.0:
sops v3.5.0:
sops v3.6.0:
At least in my case, sops v3.4.0 and v3.5.0 doesn't produce the single quotes, which v3.6.0 does. After reading #10 it seems the problem is still the same, the single quotes. It seems to me this MR in sops repository (getsops/sops#622) is related to this problem. HTH! |
Thanks for the extensive research, @davidcaste. It's probably just a matter of updating the sops dependency. I'll look into it soon. |
Should be fixed in fd68b7a. I'll release as 1.3.1 shortly. |
Should be fixed in version 1.3.1. Thanks again @davidcaste |
I just found out that the quoting behavior creates problems for other users of sops, and will be reverted: getsops/sops#706 They are going to pretend 3.6.0 never existed. If that happens I will revert fd68b7a. |
What you propose makes a lot of sense. Let's just wait for sops to release v3.6.1!! Thank you very much @jcassee ! |
Sops v3.6.1 has been released now: https://github.com/mozilla/sops/releases/tag/v3.6.1 |
@bburky @davidcaste The fix is in commit 03051c6. I'll release a new version shortly. |
Released as 1.3.2 |
I think it's related with #10 , but this time with sops v3.6.0.
I created a minimal kustomize project using sopssecretsgenerator like the following:
If I encrypt the secret using sops v3.5.0 it just works:
But if I try the same with sops v3.6.0 it fails:
If I you need any more information to reproduce this bug, please let me know!
Thank you very much for you project, I really love it!
The text was updated successfully, but these errors were encountered: