Allow snapshots using the store reference

goatslacker · Apr 26, 2015 · a25f2c8 · a25f2c8
1 parent 0563352
commit a25f2c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/alt/utils/StateFunctions.js b/src/alt/utils/StateFunctions.js
@@ -24,14 +24,15 @@ export function setAppState(instance, data, onStore) {
 
 export function snapshot(instance, ...storeNames) {
   const stores = storeNames.length ? storeNames : Object.keys(instance.stores)
-  return stores.reduce((obj, key) => {
-    const store = instance.stores[key]
+  return stores.reduce((obj, storeHandle) => {
+    const storeName = storeHandle.displayName || storeHandle
+    const store = instance.stores[storeName]
     if (store[LIFECYCLE].snapshot) {
       store[LIFECYCLE].snapshot()
     }
     const customSnapshot = store[LIFECYCLE].serialize &&
       store[LIFECYCLE].serialize()
-    obj[key] = customSnapshot ? customSnapshot : store.getState()
+    obj[storeName] = customSnapshot ? customSnapshot : store.getState()
     return obj
   }, {})
 }

diff --git a/test/index.js b/test/index.js
@@ -497,6 +497,10 @@ const tests = {
     const snapshot = alt.takeSnapshot('MyStore', 'AltSecondStore')
     assert.deepEqual(Object.keys(JSON.parse(snapshot)), ['MyStore', 'AltSecondStore'], 'the snapshot includes specified stores')
     assert.isFalse(Object.keys(JSON.parse(snapshot)).includes('LifeCycleStore'), 'the snapshot does not include unspecified stores')
+
+    const snapshot2 = alt.takeSnapshot(myStore, secondStore)
+    assert.deepEqual(Object.keys(JSON.parse(snapshot2)), ['MyStore', 'AltSecondStore'], 'the snapshot includes specified stores')
+    assert.isFalse(Object.keys(JSON.parse(snapshot2)).includes('LifeCycleStore'), 'the snapshot does not include unspecified stores')
   },
 
   'serializing/deserializing snapshot/bootstrap data'(){
@@ -793,6 +797,10 @@ const tests = {
     alt.recycle('MyStore')
     assert(myStore.getState().name === 'first', 'I can recycle specific stores')
     assert(secondStore.getState().name === 'butterfly', 'and other stores will not be recycled')
+
+    myActions.updateName('butterfly')
+    alt.recycle(myStore)
+    assert(myStore.getState().name === 'first', 'I can recycle specific stores')
   },
 
   'recycling invalid stores'() {