Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up library function spawning in base analysis #1553

Open
sim642 opened this issue Aug 5, 2024 · 0 comments
Open

Clean up library function spawning in base analysis #1553

sim642 opened this issue Aug 5, 2024 · 0 comments
Labels
cleanup Refactoring, clean-up

Comments

@sim642
Copy link
Member

sim642 commented Aug 5, 2024

Since #1029 is now done, it should be possible to clean up this TODO:

analyzer/src/analyses/base.ml

Lines 2169 to 2173 in 3ad6b39

| _, _ when get_bool "sem.unknown_function.spawn" ->
(* TODO: Remove sem.unknown_function.spawn check because it is (and should be) really done in LibraryFunctions.
But here we consider all non-ThreadCreate functions also unknown, so old-style LibraryFunctions access
definitions using `Write would still spawn because they are not truly unknown functions (missing from LibraryFunctions).
Need this to not have memmove spawn in SV-COMP. *)

@sim642 sim642 added the cleanup Refactoring, clean-up label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up
Projects
None yet
Development

No branches or pull requests

1 participant