Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unroll typedefs in witness invariants #1375

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Unroll typedefs in witness invariants #1375

merged 5 commits into from
Apr 5, 2024

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Mar 1, 2024 •
edited
Loading

Depends on #1357.

Bypass for goblint/cil#159:

  1. Unrolls typedefs in generated witness invariants, as suggested by Frontc.parse_standalone_exp doesn't handle typedef-s cil#159 (comment).
  2. The above will cause us to output some __anonstruct names from CIL, so we have to just exclude them.

TODO

  • Make this behavior optional: it's good for self-validation, but maybe bad for validation by others who can deal with typedefs.

@sim642 sim642 added bug sv-comp SV-COMP (analyses, results), witnesses pr-dependency Depends or builds on another PR, which should be merged before labels Mar 1, 2024
@sim642 sim642 added this to the SV-COMP 2025 milestone Mar 1, 2024
@sim642 sim642 self-assigned this Mar 1, 2024
Base automatically changed from yaml-witness-test to master April 4, 2024 13:05
@sim642 sim642 removed the pr-dependency Depends or builds on another PR, which should be merged before label Apr 4, 2024
@sim642 sim642 marked this pull request as ready for review April 4, 2024 13:06
@sim642 sim642 requested a review from michael-schwarz April 4, 2024 13:07
@sim642 sim642 merged commit 092eed3 into master Apr 5, 2024
21 checks passed
@sim642 sim642 deleted the witness-invariant-typedef branch April 5, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz approved these changes

Assignees

@sim642 sim642

Labels
bug sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Milestone
SV-COMP 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@sim642 @michael-schwarz