Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralization issues with Fleet #53

Closed
brycahta opened this issue Mar 11, 2022 · 1 comment · Fixed by #54
Closed

Pluralization issues with Fleet #53

brycahta opened this issue Mar 11, 2022 · 1 comment · Fixed by #54
Assignees
Labels
bug Something isn't working

Comments

@brycahta
Copy link
Contributor

Problem

Fleet is not being pluralized to Fleets.

Repro Steps

  • add {"fleet", "fleets"}, to flect_test.go
  • run make test:
--- FAIL: Test_Pluralize (0.00s)
    --- FAIL: Test_Pluralize/fleet (0.00s)
        pluralize_test.go:13: 
                Error Trace:    pluralize_test.go:13
                Error:          Not equal: 
                                expected: "fleets"
                                actual  : "fleet"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -fleets
                                +fleet
                Test:           Test_Pluralize/fleet
--- FAIL: Test_PluralizeWithSize (0.01s)
    --- FAIL: Test_PluralizeWithSize/fleet (0.00s)
        pluralize_test.go:23: 
                Error Trace:    pluralize_test.go:23
                Error:          Not equal: 
                                expected: "fleets"
                                actual  : "fleet"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -fleets
                                +fleet
                Test:           Test_PluralizeWithSize/fleet
--- FAIL: Test_Singularize (0.00s)
    --- FAIL: Test_Singularize/fleet (0.00s)
        singularize_test.go:14: 
                Error Trace:    singularize_test.go:14
                Error:          Not equal: 
                                expected: "fleet"
                                actual  : "floot"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -fleet
                                +floot
                Test:           Test_Singularize/fleet
--- FAIL: Test_SingularizeWithSize (0.01s)
    --- FAIL: Test_SingularizeWithSize/fleet (0.00s)
        singularize_test.go:24: 
                Error Trace:    singularize_test.go:24
                Error:          Not equal: 
                                expected: "fleets"
                                actual  : "fleet"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -fleets
                                +fleet
                Test:           Test_SingularizeWithSize/fleet
FAIL
@sio4 sio4 self-assigned this Mar 12, 2022
@sio4 sio4 added the bug Something isn't working label Mar 12, 2022
@sio4 sio4 linked a pull request Mar 12, 2022 that will close this issue
@sio4 sio4 closed this as completed in #54 Mar 12, 2022
@sio4
Copy link
Member

sio4 commented Mar 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants