Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cockroach DB Database Dump to use SHOW CREATE ALL TABLES #661

Closed
muya opened this issue Aug 16, 2021 · 1 comment
Closed

Update Cockroach DB Database Dump to use SHOW CREATE ALL TABLES #661

muya opened this issue Aug 16, 2021 · 1 comment

Comments

@muya
Copy link

muya commented Aug 16, 2021

Description

Command "dump" is deprecated, cockroach dump only supports --dump-mode=schema in v21.1. cockroach dump will be removed in v21.2.

More details are in this issue: cockroachdb/cockroach#54040

Additionally, a warning is popping up when one runs migrate up or migrate down against a cockroach DB; sample output:

[POP] 2021/08/16 10:13:57 info - 0.0929 seconds
Command "dump" is deprecated, cockroach dump only supports --dump-mode=schema in v21.1. 
Please use SHOW CREATE ALL TABLES moving forward.
cockroach dump will be completely removed in v21.2.
For details, see: https://github.com/cockroachdb/cockroach/issues/54040
[POP] 2021/08/16 10:13:58 info - dumped schema for...

I think that the change should be made here:

func (p *cockroach) DumpSchema(w io.Writer) error {

I'm happy to take a stab at it if no one is working on it already.

Steps to Reproduce the Problem

  1. Create and execute a migration against a cockroach database

Expected Behavior

  • Database migration executes successfully without the deprecation warning

Actual Behavior

  • Database migration executes successfully with the deprecation warning above

Info

Please precise your OS, the Pop version and if you're using Pop through Buffalo.

Pop version: v5.3.0 (using through Buffalo)
Using on macOS (11.3.1)
@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2021

#679

@aeneasr aeneasr closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants