Merge pull request #415 from goccy/fix-array-checkptr-error

Fix checkptr error for array decoder
goccy · Dec 1, 2022 · a2149a5 · a2149a5
2 parents 50a60f9 + 1480e00
commit a2149a5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/decode_test.go b/decode_test.go
@@ -4005,3 +4005,13 @@ func TestIssue384(t *testing.T) {
 		}
 	}
 }
+
+func TestIssue408(t *testing.T) {
+	type T struct {
+		Arr [2]int32 `json:"arr"`
+	}
+	var v T
+	if err := json.Unmarshal([]byte(`{"arr": [1,2]}`), &v); err != nil {
+		t.Fatal(err)
+	}
+}
diff --git a/internal/decoder/array.go b/internal/decoder/array.go
@@ -19,7 +19,9 @@ type arrayDecoder struct {
 }
 
 func newArrayDecoder(dec Decoder, elemType *runtime.Type, alen int, structName, fieldName string) *arrayDecoder {
-	zeroValue := *(*unsafe.Pointer)(unsafe_New(elemType))
+	// workaround to avoid checkptr errors. cannot use `*(*unsafe.Pointer)(unsafe_New(elemType))` directly.
+	zeroValuePtr := unsafe_New(elemType)
+	zeroValue := **(**unsafe.Pointer)(unsafe.Pointer(&zeroValuePtr))
 	return &arrayDecoder{
 		valueDecoder: dec,
 		elemType:     elemType,