Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ERC-20 extensions, like ERC-223 #212

Closed
8 tasks done
jmank88 opened this issue Jan 18, 2019 · 5 comments
Closed
8 tasks done

Support ERC-20 extensions, like ERC-223 #212

jmank88 opened this issue Jan 18, 2019 · 5 comments
Assignees

Comments

@jmank88
Copy link
Contributor

jmank88 commented Jan 18, 2019

GO/ERC-20 token contracts are recognized and displayed differently in the interface:
screenshot from 2019-01-18 07-39-59
https://explorer.gochain.io/addr/0x37C93A80b5702A820CbC3050f0e9eC48a1D5e738

The ERC223 token standard is a superset of ERC20, so it should display as a token in the interface as well, and it should be trivial to do so. There are other similar token standards as well, can we support them all automatically?

Here is an ERC223
screenshot from 2019-01-18 07-41-44

'Final' ERCs:

'Draft' ERCs:

@BeenOnChain
Copy link

image

@jmank88
Copy link
Contributor Author

jmank88 commented Jan 21, 2019

Many of these are still in 'draft' status, but we will keep an eye on them. Regardless, I would think that we could recognize at least the ERC/GO-20 subset of the interface, and work with that.

@BeenOnChain
Copy link

BeenOnChain commented Jan 21, 2019

Some of their interfaces like the 621 and 777, could be usedful.

  • Blacklisting their funds, also an option to destroy them(also decreasing supply option ;ERC621). Then replacing the amount by destroying those funds and creating new ones(also increasing Supply option ;ERC621).

  • There has to be some major governance on this though, as bad parties could increase and decrease supply whenever they feel like it. Blacklist and destroy whomever account they want, and simply generate new tokens for their own will.

  • Blacklisting an address could work in the case of someone hacking an exchange and trying to send those Go Tokens to an GO based DEX. As soon as the blacklisted address touches the DEX, it'll automatically be notified of a blacklisted address and the blacklisted address blocked from use on the DEX.

@jmank88 jmank88 mentioned this issue Jan 21, 2019
@bergauz
Copy link
Contributor

bergauz commented May 11, 2019

@jmank88 @treeder should we close this issue or will be updated periodically?

@treeder
Copy link
Contributor

treeder commented May 11, 2019

We can open separate ones for any others we want to support. Nice work!

@treeder treeder closed this as completed May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants