Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony Color Picker, SHADES mode, The wheel slides to the edge position, often does not slide #23

Open
willsame opened this issue Apr 29, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@willsame
Copy link

Harmony Color Picker,
Choose SHADES mode,
Slide the color wheel to the edge of the position, will frequently stuck, slide not move.

Record_2022-04-29-10-48-53.mp4
@ffgiraldez
Copy link
Collaborator

thanks for the report, we will loot at it

@ffgiraldez ffgiraldez added the bug Something isn't working label May 4, 2022
@riggaroo riggaroo added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 20, 2022
@prasad-333
Copy link

prasad-333 commented Nov 1, 2022

@riggaroo @ffgiraldez I did some analysis to conclude possible memory leak that might be causing this behavior.

My findings -
1] This behaviour might be there in other modes as well.
2] It could be POSSIBLE that memory leak can be in Android System file (SurfaceContol ) itself.

I raised PR #52 (it does not fix the issue )for anyone else to deep dive or use my branch for further analysis.
OR
if you want, I can comment-out the STRICT-MODE code with comments for anyone else to un-comment & check whenever required.

StrictMode log -

StrictMode              com.godaddy.android.colorpicker      D  StrictMode policy violation: android.os.strictmode.LeakedClosableViolation: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. Callsite: readFromParcel
                                                                                                        at android.os.StrictMode$AndroidCloseGuardReporter.report(StrictMode.java:1929)
                                                                                                        at dalvik.system.CloseGuard.warnIfOpen(CloseGuard.java:305)
                                                                                                        at android.view.SurfaceControl.finalize(SurfaceControl.java:1104)
                                                                                                        at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:291)
                                                                                                        at java.lang.Daemons$FinalizerDaemon.runInternal(Daemons.java:278)
                                                                                                        at java.lang.Daemons$Daemon.run(Daemons.java:139)
                                                                                                        at java.lang.Thread.run(Thread.java:923)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants