Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the --fetch/--no-fetch options in v3.0 #240

Closed
tarkatronic opened this issue Oct 26, 2021 · 1 comment · Fixed by #244
Closed

Remove the --fetch/--no-fetch options in v3.0 #240

tarkatronic opened this issue Oct 26, 2021 · 1 comment · Fixed by #244
Assignees
@sushantmimani
Labels
enhancement New feature or request
Milestone
Version 3.0

Comments

@tarkatronic
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

The --fetch/--no-fetch functionality is just weird. It only exists because it has existed since forking from truffleHog. It should no longer exist.

Describe the solution you'd like

The options are completely gone!

Describe alternatives you've considered

Switching the default to --no-fetch. But really I see no reason to leave it in at all. It should just go away. Users can easily git fetch before running tartufo, and then they have better control without weird side effects.

Teachability, Documentation, Adoption, Migration Strategy

We may want to put a note into 2.x docs that this option is being deprecated and will be removed in v3.0.
@tarkatronic tarkatronic added the enhancement New feature or request label Oct 26, 2021
@tarkatronic tarkatronic added this to the Version 3.0 milestone Oct 26, 2021
@sushantmimani sushantmimani mentioned this issue Oct 27, 2021
Merged
15 tasks
@tarkatronic tarkatronic linked a pull request Oct 27, 2021 that will close this issue
Drop support for --fetch/--no-fetch option for local scans #244
Merged
15 tasks
@sushantmimani
Copy link
Contributor

Closed by #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sushantmimani sushantmimani

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging a pull request may close this issue.

Drop support for --fetch/--no-fetch option for local scans sushantmimani/tartufo
2 participants
@tarkatronic @sushantmimani