Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object with global id not found error during transitions #346

Open
balloonpopper opened this issue Jan 3, 2023 · 3 comments
Open

Object with global id not found error during transitions #346

balloonpopper opened this issue Jan 3, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@balloonpopper
Copy link

Please make sure you talk to the community before creating an issue.

Describe the bug
I have an ESCExit (global id = alien_exit) in a room called "alien_room". I play the game and click the exit node to exit the room. If I leave my mouse inside the collision shape until the transition out starts, and then move my mouse out of the collision shape during the transition, I get the following warning.

W 0:04:06.358 call: ESC (2023-01-03T16:25:38) W esc_object_manager.gd: Object with global id alien_exit in room instance (alien_room, 14650) not found.
<C++ Source> modules/gdscript/gdscript_functions.cpp:789 @ call()
:55 @ warn()
:140 @ warn()
esc_object_manager.gd:294 @ get_object()
esc_inputs_manager.gd:395 @ _on_mouse_exited_item()
esc_item.gd:530 @ mouse_exited()
esc_inputs_manager.gd:186 @ unset_hovered_node()
esc_item.gd:304 @ _on_mouse_exited()
state_machine.gd:0 @ _physics_process()

If I leave the mouse inside the collision shape until transition out has completed, there's no error.
If I click the exit but move the mouse out before the transition starts, there's no error.

To Reproduce
As above

Expected behavior
No error

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Escoria: Latest
  • Godot: 3.5

Additional context
Add any other context about the problem here.

@balloonpopper balloonpopper added the bug Something isn't working label Jan 3, 2023
@balloonpopper balloonpopper added this to the 4.0.0 milestone Jan 3, 2023
@BHSDuncan BHSDuncan modified the milestones: 4.0.0, 4.1.0 Jan 4, 2023
@BHSDuncan
Copy link
Collaborator

I'd argue that since it's a warning (not an error), that it makes sense why it would happen, and I'm not sure there's a good way to address this other than changing the logging level.

@balloonpopper
Copy link
Author

balloonpopper commented Jan 4, 2023

I would argue otherwise. I don't know why this happens, and the error message doesn't tell me why, or that there's no way to correct it. If the message is changed so that the average developer can understand its cause and remediation steps (or that there are no remediation steps) then that would be a lot better situation.

@BHSDuncan
Copy link
Collaborator

Fair enough. In that case it's a simple case to add an additional warning message in the inputs manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants