Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint to the Comment TextEdit to denote that filling it is required #91

Open
generrosity opened this issue Nov 8, 2021 · 4 comments

Comments

@generrosity
Copy link

Hello!

This likely falls more into newbie-assistance getting used to the workflow of the plugin.

Once first opened, and once items are selected to be staged, the 'Commit Changes' button is disabled until a commit comment is added.

Could I suggest the border be highlighted once there are files waiting? I understand 'placeholder' for textfields doesn't exist.

Might I suggest having a label above the field saying "[Required] Commit Comment". Once a commit is made, it doesn't disable the button, and looks like it is quite happy to commit with empty comments. This might be intentional?

I'd also like to suggest if you disabled the button, you could put there the confirmation "committed x files" text and remove the label.

There is possibly some hover-text opportunities too.

Thanks for making the plugin available :)

@Calinou Calinou changed the title [Suggestion] Comment hint Add a hint to the Comment TextEdit to denote that filling it is required Nov 8, 2021
@twaritwaikar
Copy link
Contributor

As a part of the v2.0 efforts in godotengine/godot#53900 and #84, a "Commit Message" label was added with the new commit dock UI. For screenshots, you can view some comments at godotengine/godot#53371 (comment)

@twaritwaikar
Copy link
Contributor

Let us know if the new UI solves your concerns or if we can do something else too!

@generrosity
Copy link
Author

I see you have been hard at work! Thanks you very much for offering to hear my input

May I offer some feedback on the UI? I don't think there is a trivial way I can see it live, but I might have some suggestions to help those less familiar with Git but who are keen to use this.

@twaritwaikar
Copy link
Contributor

Yes please @generrosity, preferably under godotengine/godot#53900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants