Add a 'has conflicts' label to Godot's PR page #9453
Replies: 2 comments 5 replies
-
That would be a lot of work for maintainers to go through constantly, it's not difficult to just look at the bottom of the page, instead of adding a ton of work for maintainers who already have work as it is If it lingers long with conflicts after being approved it'll be bumped, or fixed by a maintainer, or if needed tagged with |
Beta Was this translation helpful? Give feedback.
-
Godot Team Reports tracks which PRs are in a mergeable state based on the number of approvals and whether there are merge conflicts. This works without labels needing to be manually assigned. |
Beta Was this translation helpful? Give feedback.
-
What does this discussion want you to do?
Add a 'has conflicts' label to Godot's pull request page to indicate when a pull req has file conflicts that must be resolved before merging successfully.
This is kind of in the same vein as 'breaks compat', 'needs testing' 'needs work' etc.
Is this strictly necessary?
Obviously not. It's just more convenient for us to have 'has conflicts' as a pull req label. This way we all won't have to scroll all the way down to the bottom of the page to find out if a pull req is mergeable or not.
Beta Was this translation helpful? Give feedback.
All reactions