Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep standard values when disabling default arguments in Visual Script #1235

Closed
jasperbrooks79 opened this issue Jul 21, 2020 · 2 comments
Closed

Comments

@jasperbrooks79
Copy link

jasperbrooks79 commented Jul 21, 2020

Describe the project you are working on:
A Tomb Raider game, adventure game . . .

Describe the problem or limitation you are having in your project:
I added a move_and_slide visual script box, and clicked on, use default args, to get the settings inside it . . However, when I did, all the arguments were set to zero, by default, instead of the normal numbers . . Especially, the max_slides got set to 0, it normally is 4, that made the box stop working ( it not being 4, suddenly ), without me changing the number, proposal is, when one clicks ' Use Default Args ', that the number stays the ' standard ' number, until one changes it, it makes more sense, at least for me, also if a bool is True, not set it to False, unless one actively changes it, or so . .

2020-07-21 1755

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
I spend about 2 days, trying to figure out why move_and_slide stopped working, when I expanded below max_slides, it stopped working, when I didn't, I finally after 2 days found that it somehow worked, I had to ask online, and it seemed a bit weird, idea is keep the default ' number ', so the boxes don't stop working, for little to, no reason . . .

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
It's just sort, more sense . .

If this enhancement will not be used often, can it be worked around with a few lines of script?:
This is not something I can change, atm . .

Is there a reason why this should be core and not an add-on in the asset library?:
I guess, I'm not sure, it should be engine . . . The problem, a lot of boxes could stop working, deeper in the engine, that are poorly documented, and where the default value ( 4, for max slides ) isn't known or, easily found . . Just, when clicking ' Don't Use Default Args ', keep the default value, until it is changed, by the user, also for Booleans, ie True that, become false, without user asking for it, thx . . .

@jasperbrooks79
Copy link
Author

jasperbrooks79 commented Jul 22, 2020

Basically, when I added a move_and_slide, it worked, the KinematicBody didn't walk through StaticBody walls, but when I clicked ' Use Default Args ', it suddenly began walking through walls, ie it didn't work . . It happened, because max slides is supposed to be ' 4 ', but I didn't know that, it just set it to ' 0 ', without me asking it to, I got confused, suddenly it didn't work, at all . . . I think it makes sense, to keep the default values when ' clicking ' down, to change them, UNTIL one wants a different number, from default values, ie when I click down, max slides should say 4, and not 0, same for bools that are true, and are automatically set to false . . .

When I click down, I don't want to change all of them, maybe just the last one, and it creates problems, that are difficult for new users, to understand . . I can't wait to see what visual script will become, it's just so amazing . . . To be honest, Godot is mind-blowing, massive fan . . .

@fire fire changed the title Keep standard values when disabling default args ( arguments ) in Visual script . . Keep standard values when disabling default arguments in Visual Script Jul 22, 2020
@YuriSizov
Copy link
Contributor

Closing this proposal as we have officially discontinued the VisualScript module. It may return in future as an engine extension, then all the feedback can be reevaluated by maintainers of that extension.

Thanks for your suggestion nonetheless!

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants