Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Show Grid and Enable Snap toggles in the Visual Script editor #2111

Closed
jasperbrooks79 opened this issue Jan 13, 2021 · 43 comments
Closed

Comments

@jasperbrooks79
Copy link

Describe the project you are working on

A Tomb Raider game, with epic code and, even epicer beasts and, monsters . . <3 . .

Describe the problem or limitation you are having in your project

In visual script, it's a bit annoying, when I disable the grid, that snapping also is turned off, and the boxes go sailing away, into the sky or, waters . . :O I was wondering, if in visual script, the ' show grid ' and, ' use snap ' could, not be made into separate icons, or somehow not be, connected, as it would make visual script, even nicer, to use ya ya . .

My new visual script theme, for Godot, personal gold, so cool . .

Skærmbillede (865)

No stress, just fun . . But, now I need the last feature, to be able to turn off ' grid ', but still have snap, please . .

Skærmbillede (873)

Skærmbillede (873)

The LAST thing is, the ' grid ' size ( default 20 ), it would be cool if there was a place, to set that globally, for all visual scripts, right now, even after setting it, when re-opening the same script, it goes back to 20 ( default ), by accident . .

Please, fix these issues or, problems, I can't sleep or, think, until it's done, ya ya . .

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Just the above, soon, or hurry . . More features, more code, or there riots . .

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Just, the above two ' fixes ', to make the user - experience smooth, as silk, on a pillow, that's all . . . <3 :O . . .

If this enhancement will not be used often, can it be worked around with a few lines of script?

I can't change the engine, as a new user, not yet . . Please, consider . .

Is there a reason why this should be core and not an add-on in the asset library?

Well, this is always difficult to answer, I'm not sure . . <3 <3 . . .

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79
Copy link
Author

jasperbrooks79 commented Jan 13, 2021

basically, this . . >>

Skærmbillede (874)

having these settings, maybe in a ' menu ' or, a few buttons or, drop - down buttons, would make visual script canvas ( maybe also visual shaders ), look more appealing, or fun, totally custom, you decide, what's best <3 . . Thanks . . .

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@bluenote10
Copy link

@jasperbrooks79 I just wanted to make you aware that people watching the repository get an email + GitHub notification every time you add a new message. You are by far dominating my GitHub email notifications these days, and I'm watching many big repositories. On this issue alone ~29 messages in a row. In fact, it is not unlikely that I have never received more emails from anyone else than from you 😉

Perhaps you could make your proposals more community friendly by

  • Using the edit button instead of posting new messages.
  • Before posting a proposal, think about a good and concise way to present it.
  • Leave out linguistic fillers. Your proposals are often very hard to follow, because the point you are making is buried in a lot noise.
  • Stick to standard typography. I often have a hard time e.g. understanding your usage of ' (if you put spaces on both sides it is so hard to see to which side the quote goes). Similarly if you put spaces around the dots all the time, there can be really weird line breaks. The standard way to type ellipsis ... even saves you some key strokes 😉. The ubiquitous "less than 3" statements can also be confusing, for instance when you say something like ... Godot 4 <3. For a moment I thought you mean Godot 4 is worse than Godot 3.

Any attempt to make your proposals more accessible would be highly appreciated ❤️. The energy you put into this is inspiring, and I'm sure there is a lot of value in your proposals, so it would be a pity if they don't get the attention they deserve!

@Zireael07
Copy link

<3 is just a way to write the heart emoji when someone doesn't have the emoji font.

But otherwise very good points, especially the one about editing instead of posting new messages.

@jasperbrooks79
Copy link
Author

I didn't think, you get e-mail notifications, it's not me sending them :(

Sorry, it can be confusing, also, the excitement, and so much . . .

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@jasperbrooks79

This comment was marked as off-topic.

@YuriSizov
Copy link
Contributor

Jasper, please keep proposals to a single concise idea. You've started with a simple and reasonable request to divorce snapping and grid visualization from each other and give them dedicated buttons. You've added that it might be useful to only show horizontal or vertical lines, which is, alright, but questionable.

But then you went on a tangent about other features, unrelated features. I understand your excitement, but those features are now lost to the amount of messages you leave us 🙂 It makes it that much harder to evaluate your proposals like that, and some of them are actually very useful, valuable feedback from a person who actually uses visual scripting. Can you please do me a favor and keep your ideas in short, targeted individual issue tickets? And if you have more to add on the subject of a proposal, please try to edit your original message to explain more details there.

@jasperbrooks79
Copy link
Author

Ok, I'm sorry, I learned 1 day ago, each time I post here, someone gets a new e-mail, didn't know you could subscribe to gitHub, didn't think it was like that, sorry . . <3

@Xrayez
Copy link
Contributor

Xrayez commented May 24, 2021

basically, this . . >>

Skærmbillede (874)

having these settings, maybe in a ' menu ' or, a few buttons or, drop - down buttons, would make visual script canvas ( maybe also visual shaders ), look more appealing, or fun, totally custom, you decide, what's best <3 . . Thanks . . .

This ability was discussed as part of #2662 proposal (via _draw_line() virtual method and whatnot). In theory, all those grid-based classes with snapping could be refactored to use a general-purpose node which could allow customizations like this everywhere.

Regarding the initial proposal as described in the OP, yeah I think it makes sense to have two separate buttons for this, other software I worked with do have those options as separate tools.

@YuriSizov YuriSizov changed the title Separate ' show grid ' and ' enable snap ' in Visual script . . Separate Show Grid and Enable Snap toggles in the Visual Script editor Jul 21, 2022
@YuriSizov
Copy link
Contributor

Closing this proposal as we have officially discontinued the VisualScript module. It may return in future as an engine extension, then all the feedback can be reevaluated by maintainers of that extension.

Thanks for your suggestion nonetheless!

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
@Zireael07
Copy link

Actually, this proposal also applies to visual shaders (it's generally a limitation/annoyance of the graph itself)

@YuriSizov
Copy link
Contributor

Please open a new proposal so it's easier to discuss it in the context of visual shaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants