Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnails for 3D scenes to the FileSystem dock #2493

Closed
jocamar opened this issue Mar 22, 2021 · 7 comments
Closed

Add thumbnails for 3D scenes to the FileSystem dock #2493

jocamar opened this issue Mar 22, 2021 · 7 comments

Comments

@jocamar
Copy link

jocamar commented Mar 22, 2021

Describe the project you are working on

Any 3D project in Godot 3.2/3.3.

Describe the problem or limitation you are having in your project

In the Godot workflow scenes are often used as reuseable prefabs and props for different objects in the game world. When designing a level I've found it useful to have the filesystem tab on the side open with the large icons so I can drag props to the main scene. This works well in 2D where it's easy to see at a glance what each scene is due to the thumbnails, but in 3D there are no thumbnails for some reason. This is a bit weird considering there are thumbnails for 3D assets like obj files, but not for3D scenes. It's also abit weird for people coming from other game engines who show previews and thumbnails of prefabs in the assets tab, for easy browsing.

Here you can see examples of what I mean, not how the 2D scenes get thumbnails, while the 3D ones do not:

EwykzR_XAAknkiT

EwykMCNW8AUT39M

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Allow the engine to generate thumbnails for 3D scenes as it does for 2D scenes. This can be automatic or maybe have some option for the user to provide a thumbnail for a scene if necessary.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Ideally this would work transparently, as it does for 2D scenes and 3D assets, where the engine would deal with generating the thumbnails in the background. But another option is to provide an option or button somewhere allowing the user to take a snapshot of the viewport and using that as the scene thumbnail.

If this enhancement will not be used often, can it be worked around with a few lines of script?

This is core to the engine and cannot be worked around.

Is there a reason why this should be core and not an add-on in the asset library?

This is a core engine usability feature.

@Calinou Calinou changed the title Filesystem thumbnails for 3D scenes Add thumbnails for 3D scenes to the FileSystem dock Mar 22, 2021
@Calinou
Copy link
Member

Calinou commented Mar 22, 2021

File thumbnails for 3D scenes are already supported (try hovering scene tabs in the editor), but the issue is that scene thumbnails are often not very useful due to how they're generated. The current editor camera position at the time of saving is used, which leads to unpredictable results.

My proposed solution is to add a ThumbnailCamera node for both 2D and 3D that can be used to take screenshots in a consistent manner (always using the position, rotation and FOV defined in the node). This requires some setup on the user's side, but it will lead to much more useful thumbnails. We can keep the current method when a scene doesn't have a ThumbnailCamera node.

@YuriSizov
Copy link
Contributor

YuriSizov commented Mar 22, 2021

Previews are generated for 3D scenes just as they are for 2D scenes. If you don't see that, there may be some issue with your scenes or with the engine. But we already generate previews, so the proposal is invalid.

https://github.com/godotengine/godot/blob/master/editor/editor_node.cpp#L1389

Here's a screenshot with an example of this happenening from the last time I've touched that code:

image

@jocamar
Copy link
Author

jocamar commented Mar 22, 2021

Then maybe I should submit this as a bug, because I can't get the engine to generate thumbnails for 3D scenes no matter what I do in 3.2.3/3.3.

@YuriSizov
Copy link
Contributor

Yes, it would be a good bug report with a little test project for evaluation.

@jocamar
Copy link
Author

jocamar commented Mar 22, 2021

Submitted as a bug report with a sample project (but any godot example project has the same issue to me):
godotengine/godot#47267

@jocamar
Copy link
Author

jocamar commented Mar 22, 2021

Regarding the ability to set your own thumbnails, I feel like just using the editor´s camera is more intuitive. I think having an option either on the view or perspective camera options and remembering the transform of the editor viewport camera (the same way that each scene remembers what gizmos you have turned on/off on the view options) would be the simplest way for the user.

image

@YuriSizov
Copy link
Contributor

I feel like just using the editor´s camera is more intuitive.

This already the case, the editor camera is used for generating a preview for the 3D scenes. Since what you report is a bug, and you've reported it, I'll close this proposal in favor of the bug report (godotengine/godot#47267).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants