Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Godot Splash Screen to Android 12 #4221

Closed
MiqueiasDevGames opened this issue Mar 15, 2022 · 2 comments
Closed

Migrate Godot Splash Screen to Android 12 #4221

MiqueiasDevGames opened this issue Mar 15, 2022 · 2 comments

Comments

@MiqueiasDevGames
Copy link

MiqueiasDevGames commented Mar 15, 2022

Describe the project you are working on

On android SplashScreen must be migrated to android 12.

When making the migration in one of my projects, I realized that I could control the SplashScreen through Godot using GodotPlugin tools, so that the SplashScreen is only closed when the main scene of the game is fully loaded.

I uploaded a project to Github where I show how I made these changes, changes that can be adapted to Godot, in the android template part and in the Godot part where the end of SplashScreen could work natively.

More information: https://github.com/MiqueiasDevGames/Godot-SplashScreen-Android-12

Describe the problem or limitation you are having in your project

The way I did it, I need the Background Loading Script I learned how to do here: https://docs.godotengine.org/en/stable/tutorials/io/background_loading.html

This Script with some adaptations calls the PluginSplashScreen's ExitSplashScreen() function when the defined scene is fully loaded.

So Godot could have this part natively, all this SplashScreen control would be closed when the main scene is fully loaded and the new android templates already come with the necessary changes.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Adding the functionality to close SplashScreen natively would be useful for everyone

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

In the part of Android SplashScreen that ends when a variable becomes false.

In the Godot part, make this variable false when the main scene is fully loaded.

All this is done here: https://github.com/MiqueiasDevGames/Godot-SplashScreen-Android-12/

But you can definitely adapt to work natively in godot and update the android templates to use.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Enhancement working here:
https://github.com/MiqueiasDevGames/Godot-SplashScreen-Android-12/tree/main/Script_SplashScreen

Godot is missing, I'm already configured and the android templates updated

Is there a reason why this should be core and not an add-on in the asset library?

Yes, as it works with the main scene and depends on knowing when this scene is fully loaded.

@MiqueiasDevGames
Copy link
Author

Export your game to android using my other project and see everything working: https://github.com/MiqueiasDevGames/export-godot-to-android-without-gradle-32bits-and-64bits

@Calinou Calinou changed the title Migrating Godot Splash Screen to Android 12 Migrate Godot Splash Screen to Android 12 Mar 15, 2022
@m4gr3d
Copy link

m4gr3d commented Jun 23, 2024

Fixed by godotengine/godot#92965

@m4gr3d m4gr3d closed this as completed Jun 23, 2024
@Calinou Calinou added this to the 4.3 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants