Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crutch for outside editor code generation issue #7314

Closed
kastromatos opened this issue Jul 18, 2023 · 8 comments
Closed

Crutch for outside editor code generation issue #7314

kastromatos opened this issue Jul 18, 2023 · 8 comments

Comments

@kastromatos
Copy link

Describe the project you are working on

Your first 2D game Godot tutorial, "Dodge the Creeps!" game.

Describe the problem or limitation you are having in your project

Old one known bug: Creating signals generates no code in external editor.
Create signal action in Godot not create related code section in external editor, VS 2022 in my case. Probably it is C# specific issue.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

"Connect a Signal to a Method" window should have additional section where generated template is shown. You can copy&paste template and use it outside of Godot.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

image

Or the same way as for turned on advanced option, but with code snippet:
image

If this enhancement will not be used often, can it be worked around with a few lines of script?

It should be part of Godot mono, because in most cases C# is used with external editor.

Is there a reason why this should be core and not an add-on in the asset library?

No code generation issue totally ruin experience for C# newcomers, it is a brick wall you cannot go through on very first steps in tutorial.

@AThousandShips
Copy link
Member

I'm unsure what the aim here is since this is a tracked bug and isn't intended behaviour, is this intended as a temporary fix?

@kastromatos
Copy link
Author

Two main points:

  • issue totally blocks C# newcomers on very first tutorial steps, which is very strange supposed official C# Godot support
  • original bug already lives for 3 full year and fix still not expected

For me it is relatively easy implementable feature, which should be documented as official workaround for external editors, such as VS and VS code. It is not fixing the root cause but unblocks novices and allow them to move further.

@AThousandShips
Copy link
Member

What I mean is that I think it's not the best approach to add a temporary fix instead of prioritising fixing the actual issue, as from that issue report the idea is to make it work correctly, not leave it as is

@kastromatos
Copy link
Author

@AThousandShips you are right, of course. That is why I called this issue 'crutch'. How hard is to fix initial issue? Is there some fundamental problem with it? I don't know answers and proposed workaround for this. For some reason initial issue was removed from 4.1 roadmap and milestones. Is it possible to somehow highlight it and include into plans for future mono releases?

@AThousandShips
Copy link
Member

AThousandShips commented Jul 20, 2023

I don't know why it was removed from that, but I suspect because it doesn't just affect 4.x, but no one seem to be working on it right now, so we can't really schedule a fix for it, it needs someone to pick up the issue to solve it

I would suggest in the future to discuss a workaround on the original issue before opening a proposal for it

A temporary fix is mainly appropriate, IMO, when the issue is a major one (which this, while annoying, isn't) like a bug that accidentally erases your entire documents folder, where a quick fix is necessary to prevent major problems, or where we can't make a fix that changes things because of compatibility breaking (where we can clarify documentation, or put a warning), or where we are at the mercy of upstream issues (same)

A temporary fix tends to:

  1. Delay actually fixing the issue
  2. Add code that won't really be there for long, while still being a relatively major addition in this case AFAICT

To be clear, this could be considered an alternative solution, but the presentation of it as a temporary step makes it unlikely to be approved, IMO

@kastromatos
Copy link
Author

I agree that initial code generation issue doesn't need an alternate solution and should be straightforward fixed. I hope that it will receive more upvotes and will be noticed by someone able to fix it, IMO it heavily decreases amount of C# newcomers. With all of the above I close this proposal. Thank you @AThousandShips.

@Calinou
Copy link
Member

Calinou commented Mar 4, 2024

For future reference, this is already being tracked in #3633.

@rickygai
Copy link

rickygai commented Mar 4, 2024

Actually, I understand this is four years old problem, not one year ago story. Therefore, I created a new post. Thank you all for the feedback, will look into #3633 for sure. I asked the forum, well someone asked to fix it myself which I am not that expert to do so honestly, and eventually I leave Godot for sometime, waiting this issues to be solved one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants