Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search boxes for files treat spaces the same way as search boxes for nodes #9145

Closed
MajorMcDoom opened this issue Feb 21, 2024 · 0 comments · Fixed by godotengine/godot#88660
Milestone

Comments

@MajorMcDoom
Copy link

Describe the project you are working on

This concerns an editor feature that is used in any project with many files.

Describe the problem or limitation you are having in your project

Whenever I search for a file from the FileSystem tab, or from the Quick Open Script or Quick Open Scene, I cannot use spaces to delimit specific tokens I want to include in my search. Instead it treats my entire entry as a single, exact string sequence to search against. This is very inconvenient especially in a large project where I might know parts of what a filename contains, but not the order, or what is between them.

For example, if I search for wizard skill, it returns no results if my file is named: wizard-skill.gd, wizard_skill.gd, skill_wizard.gd, or wizard_combat_skill.gd, etc. The expected behaviour is for all for these filenames to be returned if they exist.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

With this proposed change to the search box algorithm, the expected behaviour described above is achieved.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

We can refer to the existing search boxes for nodes (like the one in the Scene tab), or the project search functionality in Unity which is very similar to our own but does not have this issue.

If this enhancement will not be used often, can it be worked around with a few lines of script?

No, it is core editor functionality.

Is there a reason why this should be core and not an add-on in the asset library?

The suggested change is intended to be an improvement of a core feature for all users, not an opt-in feature for specific use cases.

@Calinou Calinou changed the title Make search boxes for files treat spaces the same way as search boxes for nodes. Make search boxes for files treat spaces the same way as search boxes for nodes Feb 21, 2024
@akien-mga akien-mga added this to the 4.3 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants