Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Project Manager settings from Editor Settings to Project Manager Settings. #9357

Closed
viksl opened this issue Mar 22, 2024 · 4 comments · Fixed by godotengine/godot#89788
Milestone

Comments

@viksl
Copy link

viksl commented Mar 22, 2024

Describe the project you are working on

Any dotnet project in 4.3.

Describe the problem or limitation you are having in your project

Currently the Project Manager automatically creates the directory from the project name which is great (and as needed) but it doesn't work well with C# standards, for example a project named "My Big Project" will have a directory named as "my-big-project".
This will also be used as the top namespace in C#.
C# doesn't use this formating so it's at least odd if nothing else.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Have the dotnet editor builds use traditional PascalCase so the "My Big Project" would produce a directory named "MyBigProject", or have a setting in settings to toggle PascalCase (godot editor already has this setting so perhaps the Project Manager could have the toggle in its own settings too?).

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Code wise no idea how this works in godot.

If this enhancement will not be used often, can it be worked around with a few lines of script?

The workaround is to disable the auto project creation, create a directory manually and browse there when creating the project.
(It doesn't feel right to disable a new functionality for this though.)

Is there a reason why this should be core and not an add-on in the asset library?

It's the project manager.

@viksl viksl changed the title Project Manager remove the dashes and use PascalCase for new (4.3) automatic project directory creation when using dotnet. Add setting to Project Manager to remove the dashes and use PascalCase for new (4.3) automatic project directory creation when using dotnet. Mar 22, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Mar 22, 2024

There is project_manager/directory_naming_convention editor setting. We could add it to the Settings menu in Project Manager, so it's more discoverable (and to allow setting it before creating project...).

@viksl
Copy link
Author

viksl commented Mar 22, 2024

Yeah, considering the functionality alread exists (I had no idea :D).
While on topic, since Project Manager has its own settings and inside the Editor Settings there are only 3, shouldn't all of that be in settings of the Project Manager to begin with?

@viksl viksl changed the title Add setting to Project Manager to remove the dashes and use PascalCase for new (4.3) automatic project directory creation when using dotnet. Move Project Manager settings from Editor Settings to Project Manager Settings. Mar 22, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Mar 22, 2024

Sorting order and default renderer can already be set from Project Manager, just not from the Settings menu. The sorting is automatically saved when you set sorting and renderer when you create a project.

tbh folder naming convention could also be a dropdown when creating project.

Some quick mockup:
image

@viksl
Copy link
Author

viksl commented Mar 22, 2024

My bad I should have realized it was already there around the manager.

When it comes to the mockup, personally I'd still shove it into settings. This feels like a clutter in the create new project dialog. Considering this kind of settings is most likely a one time toggle it doesn't seem to be necessary to have it visible every time.
Can you perhaps come up with some cases when people change this often or would need to change it often/per project basis, please? Right now I can't really come up with any reason anyone would need to change it regularly but I might be missing something here.
For example Renderer seems something you want to have everytime available, version control too but right now I just can't justify the casing/naming control element like this here.

But as far as I'm concerned as long as it's available in the Manager to begin with it's better ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants