Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightmapGI: Custom Sky environment does not contribute to ambient light #100591

Open
Tracked by #56033
michaelharmonart opened this issue Dec 19, 2024 · 3 comments
Open
Tracked by #56033

Comments

@michaelharmonart
Copy link

michaelharmonart commented Dec 19, 2024

Tested versions

Reproducible in the Godot v4.4.dev (7f5c469) build (built from the AUR and currently only a few commits behind)

System information

Godot v4.4.dev (7f5c469) - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Mon, 09 Dec 2024 11:58:37 +0000 on Wayland - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (nvidia; 565.77) - AMD Ryzen 9 9900X 12-Core Processor (24 threads)

Issue description

Currently setting the environment mode of the lightmapGI node to custom sky results in completely black bakes (assuming there are no other lights contributing bounces)

This doesn't happen when using the scene sky.

Here's a scene with the lightmapGI node set to use the scene sky:
Image

And here is the same scene when setting the lightmapGI node to use a custom sky (which is identical to the scene sky here so it's even more clear)
Image

Steps to reproduce

Create an object with UV2, and LightmapGI node.
Set the environment mode to "Custom Sky" (it doesn't matter what kind of sky material you use here, they're all broken)
Bake lighting
Notice the object is dark and not illuminated by the sky at all. (Which is clear if you change the sky energy to a stupidly high number and the object still doesn't change in brightness.)

Minimal reproduction project (MRP)

ambient-light-baking-issue.zip

This is the same scene as above but with the custom sky already set.

@AThousandShips
Copy link
Member

AThousandShips commented Dec 19, 2024

Please upload an MRP to help in testing and fixing this, to ensure everything is exactly as you are using it

Preparing an MRP is important and helpful as multiple people will almost certainly be going through and testing this bug and any potential fix, and it helps to have one single reference point to work from

@michaelharmonart
Copy link
Author

@AThousandShips I've added an MRP

@Calinou
Copy link
Member

Calinou commented Dec 21, 2024

@Calinou Calinou changed the title Custom Sky Not Contributing to Ambient Light in Lightmap Bake LightmapGI: Custom Sky environment does not contribute to ambient light Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants