Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor - full rebuild / not working (4-5 attempts) #40190

Closed
RevoluPowered opened this issue Jul 7, 2020 · 3 comments
Closed

AppVeyor - full rebuild / not working (4-5 attempts) #40190

RevoluPowered opened this issue Jul 7, 2020 · 3 comments

Comments

@RevoluPowered
Copy link
Contributor

RevoluPowered commented Jul 7, 2020

Godot PR which will not build on appveyor :
#40148

Issue description:
We have rebuilt this PR approximately 4-5 times already on request but it's not passing; not because of the PR mainly because of appveyor having a hard limit of 60m per build, which is reasonable but the resource allocated to the builds doesn't seem to be enough to complete the entire Godot build.

Honestly not got many ideas, apart from possibly splitting up or lowering the complexity of the stuff run on appveyor.

We discussed on IRC this but wanted to put an issue in for it, just in case someone has the same issue, so not really that critical I'd just like it if we can fix it somehow

Steps to reproduce:

  1. Rebuild my pr in appveyor Added doctest unit test framework #40148
  2. Build times out with "Build execution time has reached the maximum allowed time for your plan (60 minutes)."

I hope we can fix this somehow, I can manually do the testing on windows to temporarily work around this but we possibly need a more bulletproof solution.

@RevoluPowered
Copy link
Contributor Author

Working on this here #40191

will try and rule out my PR by doing a clean build, it could also be a caching issue

@RevoluPowered
Copy link
Contributor Author

Relevant fix ;) #40213 🔥 🚒

@akien-mga
Copy link
Member

Fixed by #40282.

@akien-mga akien-mga added this to the 4.0 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants