BakedLightmap (CPU lightmapper) does not use vertex colors (fixed in master with GPU lightmapper)

[NHodgesVFX]

Godot version:

Godot 3.3 RC6

OS/device including version:

RTX 2080s GLES2 & 3 Windows 10 64bit

Issue description:

The lightmapper does not take into account vertex colors.

plane lightmap

Steps to reproduce:

1. Create a basic scene that has vertex colors, with lightmap unwrapped meshes, turn on lightmap baking on the mesh and add a light in the scene)
2. add a baked light map node and fit the extents to contain the scene
3. press bake
4. notice the vertex colors don't affect the lightmaps

Minimal reproduction project:

LightMapperVertexColor.zip

[JFonS]

I will take a look at adding support for this, it should not be too complicated.

[Calinou]

@JFonS By the way, if the lightmapper isn't able to "see" which nodes use custom shaders where vertex color is not used as albedo (e.g. splatmapping), there should be a property to toggle the use of vertex colors in the lightmapper. Otherwise, indirect lighting color will appear to change for no reason when using splatmapped surfaces.

[Calinou]

This appears to be fixed in the GPU lightmapper as of commit 8f6cba3. Notice how diffuse reflections are subtly tinted to each sphere's color:

Lightmap texture (converted from EXR to PNG):

Testing project for master: LightMapperVertexColor_master.zip