Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: LightmapGI Bounce Indirect Energy property not implemented (unlike BakedLightmap in 3.x) #50938

Closed
Tracked by #56033
Calinou opened this issue Jul 27, 2021 · 1 comment

Comments

@Calinou
Copy link
Member

Calinou commented Jul 27, 2021

Godot version

4.0.dev (7bd7b8f)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 465.31)

Issue description

This issue is a reminder to implement #50827 in the master branch's GPU lightmapper.

If you are reading this and want to give it a try, feel free to open a pull request to reimplement it 🙂
Just leave a comment to let other people know, or to ask questions about the implementation.

Remember that this property should affect indirect lighting energy (bounced light) only. It should not affect direct light (when the light's bake mode is set to All) and emissive materials' lighting.

Steps to reproduce

  • Create a LightmapGI node in the master branch.
  • Select the node and look for a Bounce Indirect Energy property.

Minimal reproduction project

N/A

@BlueCube3310
Copy link
Contributor

Fixed by #82068, I think this should be closed to avoid cluttering the tracker.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants