Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer RESET track is not created (or properties added) if used Right Click Insert Key in timeline. #55438

Closed
amatrelan opened this issue Nov 29, 2021 · 3 comments · Fixed by #80860

Comments

@amatrelan
Copy link

Godot version

v3.4.stable.arch_linux

System information

Linux, x11, nvidia

Issue description

RESET animation track is not created if in timeline right click -> Insert Key is used.
It doesn't also work if this way to add is used even if RESET track is there.
Seems to be that RESET track creation and property adding is not called if this way key frame is inserted.

Expected to be created as pressing Key button in properties list.

Steps to reproduce

  • Create empty project
  • Add any node as root
  • Add AnimationNode as child
  • Create new animation
  • Add track any property
  • Right click on timeline to add Key frame

RESET track is not created. Even if RESET track is created before it won't add new properties to it.

With min project:

  • Open project
  • Select AnimationPlayer
  • Right click in timeline of modulate track
  • Insert key

And there is not RESET track

Minimal reproduction project

AnimationPlayerResetTrackProblem.zip

@Calinou
Copy link
Member

Calinou commented Nov 29, 2021

I guess this was forgotten when #43115 was implemented.

cc @RandomShaper

@KoBeWi
Copy link
Member

KoBeWi commented May 16, 2022

I think the reason why it wasn't added is that RESET animation is optional and by default it needs to be confirmed. Now imagine you get confirmation dialog every time you try to add a key. It works from the inspector, because the confirmation appears when the track doesn't exist yet.

@KoBeWi KoBeWi moved this from Todo to To Assess in 4.x Priority Issues Jun 21, 2022
@YuriSizov YuriSizov moved this from To Assess to Todo in 4.x Priority Issues Sep 12, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Feb 27, 2023
@amatrelan
Copy link
Author

I don't need that to happen every time, only times when that property is added to animation initially. There are two different ways to add property to animation, but only one of them adds RESET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants