Regression: InputEvent.is_action_pressed is true for Control+<key> even if only <key> is pressed when not using exact_match

[EIREXE]

Godot version

3.x c7f09c1

System information

Arch Linux

Issue description

When assigning a key with a modifier to an input event (such as Control+D) it works with is_action_pressed unless exact_match is specified, I believe this is a regression as this was never the behavior before. I can confirm it didn't happen in b423dc0

Steps to reproduce

Create a new input event with a modifier such as Control+d and try checking for it in an input event using InputEvent.is_action_pressed

Minimal reproduction project

mrpok.zip

[Calinou]

@EIREXE Please upload a minimal reproduction project to make this easier to troubleshoot.

[akien-mga]

Likely related to #54174, CC @nathanfranke.

[nathanfranke]

Cannot reproduce in 118494d

Both Press 1 and Press 2 (after I press Control+D) are printed.

func _ready():
	var key := InputEventKey.new()
	key.scancode = KEY_D
	key.control = true
	key.pressed = true
	if key.is_action_pressed("test", false, true):
		print("Press 1")

func _input(event):
	if event.is_action_pressed("test", false, true):
		print("Press 2")

[EIREXE]

@nathanfranke is exact_match needed now? It used to not be needed I believe the behavior has changed from before
I also tested this on 3.4.2 stable and the behavior is correct there

[EIREXE]

MRP has been uploaded, it's not too complicated though

[nathanfranke]

With exact_match = true, Control+D works
With exact_match = false, D and Control+D work

Is this what you get too?

[EIREXE]

With exact_match = true, Control+D works With exact_match = false, D and Control+D work

Is this what you get too?

Yep, that is what I get, in 3.4.2 only control d works

[nathanfranke]

I consider that expected behavior, but maybe we can get other input

[akien-mga]

Well if it's breaking compat it might be problematic. Maybe this should default to exact_match = true?

[EIREXE]

Well if it's breaking compat it might be problematic. Maybe this should default to exact_match = true?

to me that sounds like a good way to do it

[nathanfranke]

I would argue that would break more compatibility, since with exact_match = true, an input map action of D would not match Control+D by default.

Right now it behaves as the documentation describes:

If exact_match is false, it ignores the input modifiers for InputEventKey and InputEventMouseButton events

[akien-mga]

I would argue that would break more compatibility, since with exact_match = true, an input map action of D would not match Control+D by default.

Well that's how it behaves in 3.4, no?

func _input(event):
	if event.is_action_pressed("action_d"):
		print("d pressed")
	if event.is_action_pressed("action_ctrl_d"):
		print("ctrl+d pressed")

Pressing D prints d pressed. Pressing Ctrl+D prints d pressed and ctrl+d pressed.

[madmiraal]

I confirm that there has been a change in behaviour in 88e2c51 (but no change in behaviour between 3.4 and 3.4.3):

In 88e2c51 with Action: Ctrl+D:

Exact match:	False (Default)	True
Press D:	Yes	No
Press Ctrl+D:	Yes	Yes

In 3.4.3 with Action: Ctrl+D:

Exact match:	False (Default)	True
Press D:	No	No
Press Ctrl+D:	Yes	Yes

Pressing D now returns positive for an Action with Ctrl+D whereas before it didn't. Previously the parameter exact only affected actions without modifiers. Setting exact to true prevented pressing Ctrl+D from returning positive for an action: D.

In 88e2c51 with Action: D:

Exact match:	False (Default)	True
Press D:	Yes	Yes
Press Ctrl+D:	Yes	No

In 3.4.3 with Action: D:

Exact match:	False (Default)	True
Press D:	Yes	Yes
Press Ctrl+D:	Yes	No

[EricEzaM]

I would argue that would break more compatibility, since with exact_match = true, an input map action of D would not match Control+D by default.

Right now it behaves as the documentation describes:

If exact_match is false, it ignores the input modifiers for InputEventKey and InputEventMouseButton events

@nathanfranke Sorry, thats probably my bad in the way that I wrote the feature but did not write the doco for it. Doco PR: #51064 Implementation PR: #44355.

It would probably be more correct to say

If exact_match is false, it ignores additional input modifiers for InputEventKey... [etc]

If the action is Ctrl+D, we want Ctrl+D to be matched at a minimum. If additional modifiers are pressed, e.g. Ctrl+Shift+D, then exact=false allows this, whereas exact=true disallows it. I apologise for any confusion caused.