Vulkan: Toggling the SSAO Half Size option in Project Settings causes memory leak

[xiaowangxu]

Godot version

v4.0.alpha11.official [afdae67]

System information

Windows 11, Vulkan, Nvida RTX 2080 Ti

Issue description

when ssao is enabled and turn off the ssao/half_size option in Project Setting will cause memory leak
turn on half_size:

turn off half_size:

Steps to reproduce

Open any scene in godot. Enable SSAO in the WorldEnvironment, and toggle the ssao/half_size option in Project Setting and you will see the memory difference in the debugger

Minimal reproduction project

SSAO_Bug.zip

[clayjohn]

Does the memory usage continue increasing each frame or does it only increase once and then stay static?

[SmartySmart702]

Does the memory usage continue increasing each frame or does it only increase once and then stay static?

Tested for ~3 minutes and it increased continuously.

[SmartySmart702]

Same for SSIL.
Even for this:
AO: on, half size on
SSIL: off, half size off

Note that SSIL is disabled but "Half Size" on for SSIL still causes a memory leak (because AO is enabled?)

[Calinou]

It might be worth checking whether #62478 fixes this.

cc @BastiaanOlij

[BastiaanOlij]

Hmmm, yeah would be good to check if my PR already deals with it or else see if I can fix it in there as any fix will probably be lost due to the merge conflicts not picking this up properly.

That said, the code for allocating and freeing buffers used by these effects was all over the place and should be more readable in my PR. It should be easier to check and see if we forget to free something.

[allenwp]

I just tested with revision 0a420c4, which should include @BastiaanOlij's PR, on a local debug build of the editor and was able to reproduce the memory leak with the minimal reproduction project. The leak happened when either SSAO or SSIL was enabled. When both were disabled, no measurable memory leak was shown in he Debugger Monitor.

[BastiaanOlij]

Thanks @allenwp , I'll have a closer look as soon as I can, most of my PR was restructuring, not changing how it works but it should be easier now to compare allocations and whether they are being freed up.

[BastiaanOlij]

Not sure if this could be related to this issue, it may be a flow on effect, but I couldn't find any memory leak in SSAO (yet, I'll do more testing).
I did find a leak in VoxelGI: #64139 which could be triggered as SSAO is triggered.

[BastiaanOlij]

Can this be re-tested on the latest master?

[allenwp]

@BastiaanOlij This time I tested using a release_debug build, built with MSVS 14.3 x86_64 and the latest official alpha release.

Memory leak reproduced using the reproduction project that is attached to initial comment of this issue on 0a420c4, v4.0.alpha16.official [86dd3f3], and 79b21e9 (latest master).

[BastiaanOlij]

Thanks Allen, I'm going to try and see if I can reproduce it at this end.

[BastiaanOlij]

I think I fixed it, see PR #65738