Hashing methods for Font's cache do not work correctly for similar strings with different font sizes

[DmitriySalnikov]

Godot version

v4.0.beta10.official [d0398f6]

System information

Windows 10, Vulkan

Issue description

When I was testing my debug_draw_3d extension, I noticed that the graph titles change their size strangely.
For example, here, with a font size of 41 for one of the titles, instead of fps5 it draws fps6 with a font size of 14.
But the ascent of the font is taken correctly, which is why the title goes down a lot.

I found that these hashing functions create the same hash for fps5: 41, fps6: 14 and fps8: 76.

godot/scene/resources/font.cpp

Lines 273 to 291 in f7cf9fb

	uint64_t hash = p_text.hash64();
	hash = hash_djb2_one_64(p_font_size, hash);
	if (p_alignment == HORIZONTAL_ALIGNMENT_FILL) {
	hash = hash_djb2_one_64(hash_murmur3_one_float(p_width), hash);
	hash = hash_djb2_one_64(p_jst_flags.operator int64_t(), hash);
	}
	hash = hash_djb2_one_64(p_direction, hash);
	hash = hash_djb2_one_64(p_orientation, hash);
	Ref<TextLine> buffer;
	if (cache.has(hash)) {
	buffer = cache.get(hash);
	} else {
	buffer.instantiate();
	buffer->set_direction(p_direction);
	buffer->set_orientation(p_orientation);
	buffer->add_string(p_text, Ref<Font>(this), p_font_size);
	cache.insert(hash, buffer);
	}

godot/scene/resources/font.cpp

Lines 303 to 323 in f7cf9fb

	uint64_t hash = p_text.hash64();
	hash = hash_djb2_one_64(p_font_size, hash);
	hash = hash_djb2_one_64(hash_murmur3_one_float(p_width), hash);
	hash = hash_djb2_one_64(p_brk_flags.operator int64_t(), hash);
	hash = hash_djb2_one_64(p_jst_flags.operator int64_t(), hash);
	hash = hash_djb2_one_64(p_direction, hash);
	hash = hash_djb2_one_64(p_orientation, hash);
	Ref<TextParagraph> lines_buffer;
	if (cache_wrap.has(hash)) {
	lines_buffer = cache_wrap.get(hash);
	} else {
	lines_buffer.instantiate();
	lines_buffer->set_direction(p_direction);
	lines_buffer->set_orientation(p_orientation);
	lines_buffer->add_string(p_text, Ref<Font>(this), p_font_size);
	lines_buffer->set_width(p_width);
	lines_buffer->set_break_flags(p_brk_flags);
	lines_buffer->set_justification_flags(p_jst_flags);
	cache_wrap.insert(hash, lines_buffer);
	}

(also both of these parts of the code are repeated 3 times)

Here's what I get in MRP:

Expected something like this:

Affected Font methods: get_string_size, get_multiline_string_size, draw_string, draw_multiline_string, draw_string_outline, draw_multiline_string_outline.

Steps to reproduce

• Open MRP
• Notice the gray rectangles and the text somewhere near them (the text should be on top of the rectangles)
• Move the slider for the second_font_size parameter and watch glitches on some values.

Also, if you cache a lot of variants for second_font_size, and then change first_font_size(or vice versa), then there will be a more glitches:

Minimal reproduction project

Font Bad Hash.zip