Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billboard Material not working in Double Precision Build #70845

Closed
scuzzar opened this issue Jan 2, 2023 · 3 comments
Closed

Billboard Material not working in Double Precision Build #70845

scuzzar opened this issue Jan 2, 2023 · 3 comments

Comments

@scuzzar
Copy link

scuzzar commented Jan 2, 2023

Godot version

Godot 4.0 [5726770...] + precision=double

System information

Windows 11

Issue description

If i open the attatched project in my custom build using precision=double, the billboard of the particles is seaming not to work, basicaly ignoring the billboard setting all togeter.

I am using a QuadMesh as particle Mesh.

grafik

Opening the same Project in without the precision=double setting, and it is working.

grafik

Steps to reproduce

build using precision=double (i tryed several commits, all the same)

create CPUParticles3D

Add a Quad Mesh

Add a Material to the Mesh

Set Billboard to On

Minimal reproduction project

Billboard_Bug.zip

@jwatsn
Copy link

jwatsn commented Mar 5, 2023

Not sure if this will help, but I've noticed this bug is caused due to not being able to modify MODELVIEW_MATRIX in the shader vertex function when in double precision build. I found a work around:

VERTEX *= mat3(MODEL_MATRIX * mat4(VIEW_MATRIX[0], VIEW_MATRIX[1], VIEW_MATRIX[2], VIEW_MATRIX[3]));

But this wont work in things like Label3D or Sprite3D since you can't edit its shader

@cridenour
Copy link
Contributor

This will be fixed by #75462.

@Calinou
Copy link
Member

Calinou commented Apr 7, 2023

Closing in favor of #75433, which has more information about the issue at hand.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2023
@Calinou Calinou removed this from the 4.x milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants