Add node window shrinks down really small with non-standard scaling (120%) on KDE Wayland (DisplayServer regression)

[mak448a]

Godot version

4.01

System information

Fedora 37, Wayland, 125% scaling on monitor

Issue description

The add node window scales down until it's super tiny.

Steps to reproduce

Set desktop scaling to 125% on KDE Plasma Wayland, and then try adding a node. This isn't reproducible when you have desktop scaling at 100%.

Minimal reproduction project

N/A

[Calinou]

Can you take a screenshot of the editor window at 100% scale and 125% scale respectively?

Godot features its own scaling system, so you should tell the desktop environment not to scale the window and use the Display Scale editor setting instead.

[BiosElement]

Assuming this is the same bug, It actually opens at the right size, but then the bottom window collapses upward until it reaches a minimum height. This is just like resizing a window, but without user input.

I've recorded a video of what is occurring here: https://www.youtube.com/watch?v=Ceh5FRDW_8w

[Calinou]

Enabling Single Window Mode in the editor settings most likely works around the issue. Using a X11 session can probably be done to work around the issue too.

[BiosElement]

Enabling Single Window Mode in the editor settings most likely works around the issue. Using a X11 session can probably be done to work around the issue too.

I can confirm single window mode is a valid workaround. This bug does not appear for me when using X11 so it seems isolated to Wayland.

[nightblade9]

Same issue here, with the same work-around (single window mode) for me. Albeit my window shrinks a lot faster than yours @BiosElement 😂

I'm on Manjaro (Arch-based) with KDE.

[Riteo]

Yeah this is definitely related to XWayland, it has no scale awareness.

I'm adding it to #78581.

[mak448a]

It's fixed!

[romlok]

Was this actually fixed? I've just started using Wayland and am still seeing this behaviour with v4.2.1.stable.official [b09f793] - even when first opening the project manager. 😕

2024-01-15.16-57-29.mp4

I don't see any PRs linked to this issue, so was the original reporter mistaken about it getting fixed, or has there been a regression?

[mak448a]

It still works fine for me. But I'll reopen the issue for you.

[romlok]

FWIW, it seems the trigger for this happening to the project manager was that I had changed my KDE Plasma theme to have window borders - "normal" width instead of the Breeze default of none at all. I switched the borders back to default and the project manager stays at the size it opens.

Though I do still get the incredible shrinking "Add node" dialog when not in single-window mode.

I also noticed that for me the main Godot window will slightly shrink vertically every time a scene gets saved - also when in single window mode. However, one can just resize the window back up again (it doesn't show the same buggy resizing behaviour as the add node dialog).

FTR:
v4.2.1.stable.official [b09f793]
Godot v4.2.1.stable - Debian GNU/Linux trixie/sid trixie - Wayland - Vulkan (Mobile) - dedicated AMD Radeon RX 7600 (RADV GFX1102) () - AMD Ryzen 5 7600 6-Core Processor (12 Threads)

[mak448a]

@romlok What's your scaling set to?

[akien-mga]

I ran into this issue too when setting up a new laptop with KDE Wayland on Fedora 39.

The problem came from using a non-standard scaling factor of 140% in Plasma, with a 2K 16" screen. When I changed it back to 150%, it solved the issue.

@hpvb suggested this was likely an accumulation of division errors or rounding.

We are probably recalculating the the render and display sizes every frame
We probably need to just cache the results of the current settings, and only actually change anything if anything has changed
Simple struct with the window size, render size, and scale per window
And only recalculating and doing anything when the inputs change
Probably would help with other platforms too

[romlok]

@romlok What's your scaling set to?

Huh. I thought it was at 125%, but I just checked and it was set at 120%.
So it indeed seems related to a "non-standard" value, since the add node dialog behaves itself at 125% for me!

[mak448a]

Huh. I can't reproduce the add node dialog bug even at 120%.