Vulkan: Reflection probe rendering breaks if Max Distance is greater than 262144

[Calinou]

Godot version

4.1.stable

System information

Godot v4.2.dev (287f3aa) - Fedora Linux 38 (KDE Plasma) - Vulkan (Compatibility) - NVIDIA GeForce RTX 4090 (nvidia; 535.54.03) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

Reflection probe rendering breaks if Max Distance is greater than 262144. This can be reproduced in both Forward+ and Mobile rendering methods. (Compatibility doesn't have reflection probes implemented yet.)

We can probably fix this by clamping the value in set_max_distance(), so that you can't set it to a value higher than 262144 (including with the inspector's or_greater hint). See also #61492.

Max Distance = 262144

Max Distance = 262144.1

Notice how ambient light on the boxes appears slightly darker, as ambient is no longer generated correctly. It looks the same as the Disabled ambient mode.

Max Distance = 262144.1 + custom ambient color set to red

Only the automatic ambient generation is broken, not the custom color shader.

Steps to reproduce

• Create a ReflectionProbe and two meshes with a reflective material to view its results.
• Set its Max Distance to 262144. Notice the reflection and ambient light computation being functional.
• Set its Max Distance to 262144.1. Notice the reflection and ambient light breaking.

Minimal reproduction project

test_reflection_probe_max_distance.zip