Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Onion Skinning breaks Audio in Animation track #83426

Closed
VansonLeung opened this issue Oct 16, 2023 · 1 comment · Fixed by #83430
Closed

Enabling Onion Skinning breaks Audio in Animation track #83426

VansonLeung opened this issue Oct 16, 2023 · 1 comment · Fixed by #83430

Comments

@VansonLeung
Copy link

Godot version

4.2.beta.custom_build [51f81e1]

System information

macOS 11.0+

Issue description

I found another new issue when starting onion skinning while having put any audio into my animation track.

cd.mp4

Steps to reproduce

  1. Put a "playing = true" key of any MP3 audio into a Animation track
  2. Enable onion skinning
cd.mp4
  1. To temporarily dismiss the bugged audio, put a "playing = false" key of the same audio animation track just after the previous key
  2. Enable onion skinning
soln.mp4

Minimal reproduction project

gd_anim_unittest_1.zip

@AThousandShips AThousandShips changed the title [4.2.beta.custom_build] [51f81e1] Upon enabling Onion Skinning makes Audio in Animation track go crazy [4.2.beta.custom_build] [51f81e1] Upon enabling Onion Skinning breaks Audio in Animation track Oct 16, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 16, 2023
@akien-mga akien-mga changed the title [4.2.beta.custom_build] [51f81e1] Upon enabling Onion Skinning breaks Audio in Animation track Enabling Onion Skinning breaks Audio in Animation track Oct 16, 2023
@VansonLeung
Copy link
Author

VansonLeung commented Oct 16, 2023

By referring to:

#83436

@KoBeWi corrected me the proper practice when adding audio tracks into animation.

By following that proper practice, this bug may not be reproducible.

@RandomShaper @akien-mga We may close this issue upon your decisions.

Sorry for any confusion caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants