Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving nodes around the tree in a scene with baked lightmap triggers lightmap reimport #83444

Closed
atirut-w opened this issue Oct 16, 2023 · 7 comments · Fixed by #77788
Closed

Comments

@atirut-w
Copy link
Contributor

Godot version

v4.2.beta.custom_build [a60fc7f]

System information

Godot v4.2.beta (a60fc7f) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 27.20.21034.37) - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)

Issue description

When you move any node around within the tree of a scene with baked lightmap, a reimport of the lightmap file will be triggered.

Steps to reproduce

  1. Set up a scene with some lightmapped meshes. Also create one dynamically lit object for testing reason.
  2. Bake lightmap
  3. Move any node around in the scene tree
  4. A reimport will be triggered.

Minimal reproduction project

Lightmap Reimport.zip

@AThousandShips
Copy link
Member

AThousandShips commented Oct 16, 2023

Can you reproduce this on earlier development snapshots or versions?

@atirut-w
Copy link
Contributor Author

I can reproduce this on 4.2 Beta 1.

@AThousandShips
Copy link
Member

And further back?

@atirut-w
Copy link
Contributor Author

I went back to b137180 and it seems to be present. Further testing will have to wait for tomorrow since it's very late at night here.

@bitsawer
Copy link
Member

There is a PR that might also improve this behavior, but I haven't tested it: #77788

@atirut-w
Copy link
Contributor Author

atirut-w commented Oct 17, 2023

Found a good commit. I'll start a git bisect and see what caused this bug. Will also check out #77788.

Commit SHA in case anyone want it: ce236a6
New good commit: fab1c6f
New bad commit: 3a990e3

@atirut-w
Copy link
Contributor Author

atirut-w commented Oct 17, 2023

It seems that this was exposed (read: not introduced) in 42a3108, and that #77788 not only improved the behavior, but actually fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants