Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in lightmap UV unwrapping in godot 4.2.beta4 #84373

Closed
LimaneGaya opened this issue Nov 2, 2023 · 5 comments · Fixed by #84374
Closed

Regression in lightmap UV unwrapping in godot 4.2.beta4 #84373

LimaneGaya opened this issue Nov 2, 2023 · 5 comments · Fixed by #84374

Comments

@LimaneGaya
Copy link

Godot version

4.2.beta4

System information

Windows 11, Godot 4.2.beta4, Forward +

Issue description

unwrapping UV in models imported shows error while it works fine in godot 4.1
Capture d'écran 2023-11-02 175424

Steps to reproduce

import model
extract meshes
place it in a scene
try to unwrap uv

Minimal reproduction project

lightmap beta4.zip

@YuriSizov
Copy link
Contributor

This error was added on purpose in #83498. It's supposed to tell you about something that would fail the unwrapping later regardless. cc @SaracenOne

@AThousandShips
Copy link
Member

Can you confirm that it worked correctly in 4.1? As in more than just it not showing a popup? Is it free of error messages and produces a valid result?

@LimaneGaya
Copy link
Author

Yes it works fine in Godot_v4.1.3-stable

Capture d'écran 2023-11-02 182109

@AThousandShips
Copy link
Member

Oh wait, it looks like the condition is invalid in the PR:

if (format & Mesh::ArrayFormat::ARRAY_FORMAT_NORMAL) {

Looks inverted

@AThousandShips AThousandShips added this to the 4.2 milestone Nov 2, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Nov 2, 2023

I'll just throw together a fix

Edit: confirmed that it makes the error go away for the MRP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants