Editor crashes when reimporting more than one asset at a time

[PickyDogFish]

Godot version

4.2.rc1

System information

Godot v4.2.rc1 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (NVIDIA; 31.0.15.4617) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)

Issue description

Importing more than one file at once crashes the engine. Dragging and dropping more than one file into the filesystem dock from outside the editor crashes the editor in the middle of (re)importing assets. The same thing happens if you move more than one asset from one folder to another in the editor.

Steps to reproduce

• Duplicate icon.svg
• Make two folders
• Drag both icons between folders a few times
• Engine crashes on (re)importing assets

Minimal reproduction project

CrashTest.zip

[akien-mga]

I can't reproduce on Linux, this might be Windows specific (didn't test).

[PickyDogFish]

I also can't seem to reproduce it on Linux (steamdeck). On Windows it happens pretty consistently, but not every time.

[culapyro]

Importing multiple resource editors on Windows crashes

[ShlomiRex]

I can't reproduce in 4.1.3 stable or v4.2.rc.custom_build [80de898] on Windows

[YuriSizov]

Can you provide the exact project that crashes? I've tested multiple projects for the last few weeks to debug various importing and conversion problems, and never had a crash on Windows. Also can't reproduce this with the steps described in the OP.

Can you also try doing this with a clean copy of the editor? You can do this by copying your Godot executables somewhere else and initializing the self-contained mode.

[PickyDogFish]

@YuriSizov I added the exact project to the OP. For me, it crashes when I first open the project. If I try opening it again it works, but still crashes if I move the assets around.

I tried doing it with a clean copy, in the self-contained mode. The crash still happened after moving the assets from folder to folder a couple of times.

If I can somehow provide more data let me know, I'll be glad to do it.

[ShlomiRex]

Tested again with the OP's CrashTest.zip project file, still it doesn't crash on either 4.1.3 stable or 4.2.rc custom.

[YuriSizov]

@PickyDogFish Unfortunately, I cannot reproduce the problem either. Could you start the editor from the command line and using the *console.exe executable with the verbose flag, and try to do what triggers the issue for you and then check back in the command line if there is anything useful?

Godot_v4.2-rc1_win64_console.exe -e --path path/to/your/project --verbose

[PickyDogFish]

It seems like the change that breaks it for me was introduced in 4.2.beta6. Beta5 works okay, in beta6 and rc1 it crashes.

[ShlomiRex]

@PickyDogFish what is the hash of git?

[PickyDogFish]

This is all I get in the command line:

Moving res://icon2.svg -> res://TestFolder2/icon2.svg
  Remap: res://icon2.svg -> res://TestFolder2/icon2.svg
Moving res://icon.svg -> res://TestFolder2/icon.svg
  Remap: res://icon.svg -> res://TestFolder2/icon.svg
FileSystem: calling rescan.

[YuriSizov]

Could you please post the entire log? With the verbose flag there ought to be dozens of messages.

[PickyDogFish]

Sure, here's the full log:

Godot Engine v4.2.rc1.official.ad72de508 - https://godotengine.org
TextServer: Added interface "Dummy"
TextServer: Added interface "ICU / HarfBuzz / Graphite (Built-in)"
WARNING: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
        windows_read_data_files_in_registry: Registry lookup failed to get layer manifest files.
        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 1523828469648
     at: _debug_messenger_callback (drivers/vulkan/vulkan_context.cpp:264)
Vulkan devices:
  #0: NVIDIA NVIDIA GeForce RTX 3060 Ti - Supported, Discrete
Vulkan API 1.3.260 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Ti
Optional extension VK_KHR_incremental_present not found
Optional extension VK_GOOGLE_display_timing not found
- Vulkan Variable Rate Shading supported:
  Pipeline fragment shading rate
  Primitive fragment shading rate
  Attachment fragment shading rate, min texel size: (16, 16), max texel size: (16, 16)
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGV
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELAV
  quad operations in all stages
Startup PSO cache (3.4 MiB)
Using "wintab" pen tablet driver...
Creating VMA small objects pool for memory type index 1
Shader 'CanvasSdfShaderRD' (group 0) SHA256: 483b6ad979f71a8ca31e24b6d830155d9592ffb7a6ac63a7356ca8a27d3531c6
Shader 'SkeletonShaderRD' (group 0) SHA256: 14bba0c14540c70a16d4d2be549e9c934bb6fa0a76f3b06bb11503e4f8d38ca0
Shader 'SortShaderRD' (group 0) SHA256: 662216ccb4abff22cc6d56bac8b63ed77ebfadc8dd93869e8ee59ea0fee6b760
Shader 'ParticlesShaderRD' (group 0) SHA256: 5440dc219c9d08fc5682d2c08fe588f8d2258d693f589df777125abbc65621cb
Shader 'ParticlesCopyShaderRD' (group 0) SHA256: 52cfcab1bf1067f6bf4e09c8ea72cd7ea9b624282c856a839199b54cec0beb12
Shader 'CanvasShaderRD' (group 0) SHA256: 0e9bd6c3a7d95f182cb863ef0bf4a4cb3093131adbeb500ad7f27065d5a0fe61
Shader 'CanvasOcclusionShaderRD' (group 0) SHA256: 183552f52abfad92e93467a79878883478fa6c33e756321b0f1c4ccedb54f32a
Shader 'ClusterRenderShaderRD' (group 0) SHA256: aa2d9f21367e2b7b7363bb01d47c674773a9fe8b2217d3f588ed48d7086f739a
Shader 'ClusterStoreShaderRD' (group 0) SHA256: cf778e611c804041aa2df40a7d9320771a12d4b5971a9c7c8ce4a7e1a2288344
Shader 'ClusterDebugShaderRD' (group 0) SHA256: f50a5b883ada1c492e318d0ca1dde9d726aa94fc5ff60aacf4d9b89f105f4b47
Shader 'SceneForwardClusteredShaderRD' (group 0) SHA256: 900e8276cbcf9fae337352857c8757bab437d9f6bb84544c67315049d19c561
Shader 'SceneForwardClusteredShaderRD' (group 1) SHA256: 7df294f2ccf0c92a01edd5c4c297bf4d2c0fa201298d26c49fb4fb968ba1f1f
Shader 'SceneForwardClusteredShaderRD' (group 2) SHA256: b2a6589dcd10f23f7b73dc84efabf7a37280c428dec44866dd4a0bdd997472e
Shader 'SceneForwardClusteredShaderRD' (group 3) SHA256: 85341a863de6031e5e5c01c725aec83e17f516f2f5d0366beccb10dab0d16c2
Shader 'ResolveShaderRD' (group 0) SHA256: d15ee43114eb76352c0243dd570aade6f6ee9448a984cd2bf753e0d592a76ed2
Shader 'TaaResolveShaderRD' (group 0) SHA256: e359d5b9a0fc2e3235ca93da4e399050437c9b635957c153b951f84f8cdf1e92
Shader 'Fsr2DepthClipPassShaderRD' (group 0) SHA256: 5e17343848233e2a08731aa3aaa7c4a748bb4fffac83872b325c23c09dcaad5d
Shader 'Fsr2ReconstructPreviousDepthPassShaderRD' (group 0) SHA256: 77a8f9f905524d86de8f0ae2c37bc3af424414336bf2e2fdc49c
Shader 'Fsr2LockPassShaderRD' (group 0) SHA256: 38ab851e8dbb0c077947da9b9e3d7c5838da93ae53130400ba52dcffafc94545
Shader 'Fsr2AccumulatePassShaderRD' (group 0) SHA256: 42024e3bacbfd0389f74f9906f4bbcbf8981a42b6b4ba0fc339214c7a9e01238
Shader 'Fsr2RcasPassShaderRD' (group 0) SHA256: 1c2113c9bfc2128ed8e5f55dd850724781d22dd105ece1850b91c96f2ff22ff0
Shader 'Fsr2ComputeLuminancePyramidPassShaderRD' (group 0) SHA256: d715edadc99a3defa7f600beecdfc96d7a2216e570f7f3fbe03cd
Shader 'Fsr2AutogenReactivePassShaderRD' (group 0) SHA256: 8a8d76558488f1b14c915ffc7f2bb89fe4e7f20f359648e053091c6a125be
Shader 'Fsr2TcrAutogenPassShaderRD' (group 0) SHA256: f33d7cbe3518ff03e1c80a52aeda3fab57aa2e425265d6de657d10496add6a8c
Shader 'SsEffectsDownsampleShaderRD' (group 0) SHA256: d1e57c5107aa3a9a516bec6e4efd7efd4a59d66b248c22b12cd974a60f6f1adf
Shader 'SsilShaderRD' (group 0) SHA256: d5bd353e0c8cd3b41a4cf134fab0da2db21ab620498935f0699a82b9afe5d99b
Shader 'SsilImportanceMapShaderRD' (group 0) SHA256: 94ebe0f192bcc008bc5435fb9abda37c5fca9b3c28c5846fd5288a96ee396693
Shader 'SsilBlurShaderRD' (group 0) SHA256: 559ec4464f7ba1242618cae58d227c93de10fdd4d237ea34853ab68f907185df
Shader 'SsilInterleaveShaderRD' (group 0) SHA256: 06523c92113a33042b97f5bc386d7eca5247f7352d84fe53bc6ca676ed354d03
Shader 'SsaoShaderRD' (group 0) SHA256: 0abcc59c80a85a3df27e033d828cbd659ae931ec9d5bba23330b14e20e0ea671
Shader 'SsaoImportanceMapShaderRD' (group 0) SHA256: 6898764a8125aa32ed544466329eecbc2ac3ed8b8f6661cdd11e2d0ae3c00c75
Shader 'SsaoBlurShaderRD' (group 0) SHA256: 7c1af94ec2fba9a9ff3c356b76c9a3d3c4c2d4031c0d099f4042cf43ecd4fa23
Shader 'SsaoInterleaveShaderRD' (group 0) SHA256: 6642ebddf959fb1cd28298bd7ab55917ac1f059ef506f2d54355ccb443f8a94d
Shader 'ScreenSpaceReflectionScaleShaderRD' (group 0) SHA256: 9bf9ded00b0d1f99de455f9628c1b0789efefc2e35358d9cfcdc8418a2
Shader 'ScreenSpaceReflectionShaderRD' (group 0) SHA256: 2636bc22b6345ccae3bbf6322860f736e7196fa288a1be0c6d2c0b023bb320d
Shader 'ScreenSpaceReflectionFilterShaderRD' (group 0) SHA256: 21e18310a270478c3e43d8aaab1dfd02130d27cc81becc3c9a253be44
Shader 'SubsurfaceScatteringShaderRD' (group 0) SHA256: 7735985a57f2b3663508a36cd361dfc2bfeab3a19ccca68eb7cec687957f2f06
Shader 'SkyShaderRD' (group 0) SHA256: e31363353de0de11c93a210495e5dac407f9924fedf3138c5a0bd8a7e7a4acdc
Shader 'VoxelGiShaderRD' (group 0) SHA256: b7c604186250cdf698328c76cd02c9cb0f7d968bbb3bd24a4095c927fb74f871
Shader 'VoxelGiDebugShaderRD' (group 0) SHA256: 90b491805ff64de0fbc9694d3aa6d469f4556867f1a1c7273d604e5f9be3e6fc
Shader 'SdfgiPreprocessShaderRD' (group 0) SHA256: 591ab1f5d28638cf504e42d7113bc8eeca8b348b254991b4481178f1d32cf5ab
Shader 'SdfgiDirectLightShaderRD' (group 0) SHA256: 1cf5151f7aeb0a5f23fb3e1932cb04535c2082f635f6e5cba4d662894a1ae749
Shader 'SdfgiIntegrateShaderRD' (group 0) SHA256: 8925247357d9945ca0d638c5604bd0a295c4aff459720a2698b3df59599ab872
Shader 'GiShaderRD' (group 0) SHA256: 6fbde9d9b60b3b69305bc66e82101a29ed35ad0c47420f06b7dec6bdf934c328
Shader 'SdfgiDebugShaderRD' (group 0) SHA256: 66a0a56964254d50043d21b996efbb535fb046f253c57226778bdcc9a4eaa9fc
Shader 'SdfgiDebugProbesShaderRD' (group 0) SHA256: 5997c706fba83152a7d5d9661a2b0941d5e09f03c9dc953e4fb8fb5ee3daaaf9
Shader 'VolumetricFogShaderRD' (group 0) SHA256: 8d82db523d850521b7e0bf8ec7d53a8aa0f0004168888300ac1e175ba1e1021c
Shader 'VolumetricFogProcessShaderRD' (group 0) SHA256: 13d38f1a033e306f3dbd6fd7ffa836d076f594a591667a6f36d3d4945af2d369
Shader 'BokehDofShaderRD' (group 0) SHA256: 25de865daf3c560b0d6655ea87ac4a32f0749cac9db56f3e3fdb11c035d56371
Shader 'CopyShaderRD' (group 0) SHA256: 9d2753704a9ee5bae491893fddbfa29b761b2ae4ba4cc69b163acba209310372
Shader 'CopyToFbShaderRD' (group 0) SHA256: 54b1ab25a6bb18fe54840a04963099b70f9c55d4f5d06064b1a59d60663d15ab
Shader 'CubeToDpShaderRD' (group 0) SHA256: b3e5f832d11fa6e0404bdd30e503cca6865b0986c4ed48a89ed1c89fa4f40a15
Shader 'CubemapDownsamplerShaderRD' (group 0) SHA256: c3cebf00018fc4fa4b91b2b3552b77c723ba0f79c9b9d2fe2639ddbff52e85e9
Shader 'CubemapFilterShaderRD' (group 0) SHA256: 29dd7a9d5fef37a83cebc9fd63f19fd29a7aceed5046ad84dc89916f83ff2826
Shader 'CubemapRoughnessShaderRD' (group 0) SHA256: aa313a27632d30a9d49a8db56b21b5b02ef01c2df1ab34c6d76f7807d2f4a42b
Shader 'SpecularMergeShaderRD' (group 0) SHA256: 9cc164b86da2c25ea76ddc462846bb8ae121dea83fd54114669adb6876c16a34
Shader 'ShadowFrustumShaderRD' (group 0) SHA256: 029c44065c791caeaf961c9b9d89de41908980c2cccfb83f6a20ee2ea8d7d339
Shader 'MotionVectorsShaderRD' (group 0) SHA256: 86e2a7f8ec16d54747e270b30abf58ddf2a5a5d94f1c576db87a1214177418ef
Shader 'LuminanceReduceShaderRD' (group 0) SHA256: 3bd21eb192a7ed174dbc949f67b458a104b7401b7486c22e03cc30b9d68b928a
Shader 'TonemapShaderRD' (group 0) SHA256: d256757b9fb591267b318d70987f5fd0bcae60c3f61cc47db57f07cdfbaa6e99
Shader 'VrsShaderRD' (group 0) SHA256: 6986d314f5ef7b1125095a35dfe15ac57959b30c55b10ca3a7b05ac12141d0cc
Shader 'FsrUpscaleShaderRD' (group 0) SHA256: 0c66951d23bcd7cd04052725d145b07619547bac97c5fdb9e003e6813cd4b182
Shader 'BlitShaderRD' (group 0) SHA256: 26d9beafc97c64060a27bea2cdea7d19366f5204a6e82f5b740c6561e3d8da0a
WASAPI: Activated output_device using IAudioClient3 interface
WASAPI: wFormatTag = 65534
WASAPI: nChannels = 2
WASAPI: nSamplesPerSec = 48000
WASAPI: nAvgBytesPerSec = 384000
WASAPI: nBlockAlign = 8
WASAPI: wBitsPerSample = 32
WASAPI: cbSize = 22
WASAPI: mix_rate = 48000
WASAPI: fundamental_period_frames = 480
WASAPI: min_period_frames = 480
WASAPI: max_period_frames = 480
WASAPI: selected a period frame size of 480
WASAPI: detected 2 channels
WASAPI: audio buffer frames: 480 calculated latency: 10ms

TextServer: Primary interface set to: "ICU / HarfBuzz / Graphite (Built-in)".
CORE API HASH: 2018839987
EDITOR API HASH: 425094879
EditorSettings: Load OK!
WARNING: Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings.
     at: _editor_init (modules/gltf/register_types.cpp:63)
Loaded system CA certificates
Creating VMA small objects pool for memory type index 3
EditorSettings: Save OK!
Moving res://TestFolder/icon2.svg -> res://TestFolder2/icon2.svg
  Remap: res://TestFolder/icon2.svg -> res://TestFolder2/icon2.svg
Moving res://TestFolder/icon.svg -> res://TestFolder2/icon.svg
  Remap: res://TestFolder/icon.svg -> res://TestFolder2/icon.svg
FileSystem: calling rescan.

[YuriSizov]

Okay, I was able to reproduce it with the official build of 4.2.rc1. Can't reproduce with my own builds (so can't debug it), but this strongly suggests it's an issue with mingw and threading which we've identified before and #85039 might fix. Which is a risky PR, so we have to assess it very thoughtfully.

[YuriSizov]

Confirmed to be fixed by #85039 if built with mingw, by the way. But we aren't very excited to replace something so core so late. So we'll probably need a different solution, more precise and addressing the actual regression caused by recent changes.