Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightmap frustum culling on scaled objects #87604

Closed
passivestar opened this issue Jan 26, 2024 · 3 comments
Closed

Lightmap frustum culling on scaled objects #87604

passivestar opened this issue Jan 26, 2024 · 3 comments

Comments

@passivestar
Copy link
Contributor

Tested versions

v4.2.1.stable.official [b09f793]

System information

Godot v4.2.1.stable - macOS 14.2.1 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

Issue description

Lightmap culling doesn't seem to take object scale into account?

culling.mp4

Steps to reproduce

Open MRP and scale LevelE_001

Minimal reproduction project (MRP)

MRP_Lightmaps.zip

@clayjohn
Copy link
Member

I feel like different iterations of this bug keep popping up randomly.

If I am remembering correctly, we've discussed this before and agreed that the ideal solution is to disable culling for lightmaps. They are registered with the meshes that were baked with them, so if those meshes are visible, the lightmap should be visible.

@passivestar
Copy link
Contributor Author

if those meshes are visible, the lightmap should be visible.

yeah that sounds reasonable to me

@Calinou
Copy link
Member

Calinou commented Jan 26, 2024

Thanks for the report! Consolidating in #71585, as this is due to the same cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants