Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cracking sound in Samsung Internet #88857

Open
Tracked by #76797
kaiec opened this issue Feb 26, 2024 · 4 comments
Open
Tracked by #76797

Cracking sound in Samsung Internet #88857

kaiec opened this issue Feb 26, 2024 · 4 comments

Comments

@kaiec
Copy link

kaiec commented Feb 26, 2024

Tested versions

4.2.1

System information

HTML5 Web export, on Samsung Browser (Samsung Galaxy A52S), confirmed in several other Samsung devices

Issue description

When running an HTML export in the Samsung Browser (which is the default browser on many Samsung devices when links are opened in WhatsApp or Discord), the sound is cracking. It improves when the latency is set to its maximum of 100, but it is still there. Tested with all kinds of mix rate combinations (0 to 48000), makes no difference.

Saw this also in other games developed in Godot for a game jam. Unity games do not show such an issue. Everything else runs fine in the Samsung Browser so this is really bad as many people share links to games via WhatsApp and then the Audio is broken while everything runs fine in Chrome Mobile.

Steps to reproduce

New project, add an audio stream player, use any kind of music file to play, be it ogg, mp3 or wav, any mix rate. Export to HTML5, open in Samsung Browser on an Android device.

Here is a published test project: https://kaiec.itch.io/samsung-godot-test

Minimal reproduction project (MRP)

godot-samsung.zip

@kaiec
Copy link
Author

kaiec commented Feb 26, 2024

Some more infos: I use Samsung Internet (the official name) in the latest Version 23.0.1.1. The browser is based on Chromium, which is weird considering that Chrome does not have these problems. Edge, which is also Chromium-based, also seems to work fine. More info about the browser: https://en.wikipedia.org/wiki/Samsung_Internet

Update: The beta version has the same problem.

@adamscott
Copy link
Member

Did you export your game with the no-thread option? If so, this is a duplicate of #87329 and not related at all with Samsung Internet.

@adamscott adamscott self-assigned this Feb 26, 2024
@kaiec
Copy link
Author

kaiec commented Feb 27, 2024

No, I left all settings on default for the MRP. I am on 4.2.1, where the setting is not included as far as I know. The sound works perfectly fine on all other exports and for the Web export the sound works on Desktop Firefox, Desktop Chrome and Android Chrome and Edge (both Chromium). Only Samsung Internet is not working, which unfortunately is a widely used browser due to being the default browser on all Samsung phones.

@Calinou Calinou changed the title Cracking sound in Samsung Browser Cracking sound in Samsung Internet Feb 27, 2024
@kus04e4ek
Copy link
Contributor

kus04e4ek commented Jun 10, 2024

#90906 was probably a duplicate of this, it's fixed in 4.3 and the fix is planned to be cherry-picked for 4.2, try to use 4.3 beta 1 or set audio/driver/output_latency (not audio/driver/output_latency.web, just audio/driver/output_latency) to 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants