Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going backward and forward in the inspector's edited history multi-select nodes in the scene tree when it should not #90636

Closed
AeioMuch opened this issue Apr 13, 2024 · 0 comments · Fixed by #90653

Comments

@AeioMuch
Copy link
Contributor

Tested versions

  • Reproducible from 4.1.dev3 up to current 4.3.dev master (578d937)
  • Not reproducible in 4.1.dev2 and before

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 31.0.15.5212) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)

Issue description

Since 4.1.dev3, when going backward and forward in the edited objects history, it adds to the selection (multi-select) all the inspected nodes, when multi-select should only happen when you are going back in history where you had actually selected multiples nodes (which does not work properly anyway as seen in the video) :

Godot_v4.1-dev3_win64_CbVdhbnOS6.mp4

In 4.1.dev2 and before, it selected only the correct node as expected, but also fail to multi-select the correct nodes if the history point was more than 1 nodes selected, as seen in this video :

Godot_v4.1-dev2_win64_grq6vIvQHB.mp4

Steps to reproduce

  1. Create scene
  2. Add child nodes
  3. Use the edited nodes history backward and forward button or the list
  4. Witness the behaviour

Minimal reproduction project (MRP)

N/A

@AeioMuch AeioMuch changed the title Going backward and forward in the Edited History multi-select nodes in the SceneTree when it should not Going backward and forward in the inspector's edited history multi-select nodes in the scene tree when it should not Apr 13, 2024
@akien-mga akien-mga added this to the 4.3 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants