[Source Generator] Unable to disable multiple source generators using GodotDisabledSourceGenerators property

[Panthr75]

Tested versions

Godot

Based on looking at the github, all versions have this bug

• 4.2.1

Visual Studio

• 17.9.0
• 17.9.7

System information

Windows 10 - x64 - vs17.9.7

Issue description

For some reason C# source generators attempting to access global config properties that have a value with a ; in them result in said value getting truncated.

For example:

<Project Sdk="Godot.NET.Sdk/4.2.1">
  <!-- ... -->

  <PropertyGroup>
    <GodotDisabledSourceGenerators>GodotPluginsInitializer;ScriptPathAttribute</GodotDisabledSourceGenerators>
  </PropertyGroup>
</Project>

When the source generators run, they only see the value GodotPluginsInitializer for the GodotDisabledSourceGenerators property even though the generated GeneratedMSBuildEditorConfig.editorconfig has build_property.GodotDisabledSourceGenerators set to GodotPluginsInitializer;ScriptPathAttribute

I wrote my own Source Generator to verify.

This is what's inside the GeneratorExecutionContext:

But note this is the generated GeneratedMSBuildEditorConfig.editorconfig that is created inside the obj folder:

The values of GodotDisabledSourceGenerators in the source generator conflict with the values inside the editor config.

To fix this issue, the separator can be changed from a ; to a ,.

Steps to reproduce

1. Edit the csproj file of a C# Godot Project to include the following line in between a <PropertyGroup> tag in Visual Studio 2022:

<GodotDisabledSourceGenerators>GodotPluginsInitializer;ScriptPathAttribute</GodotDisabledSourceGenerators>

2. Add the following class to the project:

using Godot;

public partial class DummyClass : Resource
{
}

3. Build the C# Godot Project
4. Inspect the C# Godot Project with ILSpy or an equivalent
5. Notice the GodotPlugins.Game was not generated
6. Decompile DummyClass
7. DummyClass has the ScriptPathAttribute on it, even though the ScriptPathAttribute source generator was meant to be disabled.

Minimal reproduction project (MRP)

N/A

[raulsntos]

In editorconfig ; is the comment character, so everything after it is ignored. This is unfortunate since in MSBuild ; is the separator character.

In editorconfig/specification#31 the editorconfig specificaition was updated to clarify that ; and is only a comment when it's at the beginning of the line, thus allowing MSBuild to use ; as a separator character.

However Roslyn still needs to be updated to follow the updated specification:

• EditorConfig comments cannot follow a property value dotnet/roslyn#51625.