"--test" cannot be used as a user-provided argument after the separator (either "--" or "++") anymore

[krova]

Tested versions

Introduced in 4.3
Worked fine in 4.2.2

System information

Windows 10 / Ubuntu 22.04, Godot 4.3

Issue description

Hey,
I believe v4.3 broke the "--" separator for user-provided arguments.
As per the documentation: "Following arguments are not used by the engine, but can be read from OS.get_cmdline_user_args()."

This was true in v4.2.2:

Godot_v4.2.2-stable_mono_win64_console.exe --headless --path Path/To/My/Game -v -- --test
Godot Engine v4.2.2.stable.mono.official.15073afe3 - https://godotengine.org
TextServer: Added interface "Dummy"
TextServer: Added interface "ICU / HarfBuzz / Graphite (Built-in)"
Using "default" pen tablet driver...
TextServer: Primary interface set to: "ICU / HarfBuzz / Graphite (Built-in)".
.NET: Initializing module...
Found hostfxr: C:\Program Files\dotnet\host/fxr/8.0.8/hostfxr.dll
.NET: hostfxr initialized
.NET: GodotPlugins initialized
CORE API HASH: 622119089
EDITOR API HASH: 497707466
Loaded system CA certificates
My custom game test is starting...

However, in the 4.3 version it stopped working:

Godot_v4.3-stable_mono_win64_console.exe --headless --path Path/To/My/Game -v -- --test
ERROR: --test was specified on the command line, but this Godot binary was compiled without support for unit tests. Aborting.
To be able to run unit tests, use the tests=yes SCons option when compiling Godot.

I do not want to run unit tests.
I did not specify --test as a Godot flag.
I only wanted to pass my own argument, after the "--" separator.

Steps to reproduce

Just run:

Godot_v4.3-stable_mono_win64_console.exe -- --test

Minimal reproduction project (MRP)

Just run:

Godot_v4.3-stable_mono_win64_console.exe -- --test

[Calinou]

This is a regression from #90507.

Note that the existing check in place was also flawed, as it did not check whether --test was specified before --. If it's specified after --, Godot should ignore it.

[Dowsley]

@Calinou Made a PR for this.