Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward+/Mobile: Shadow filtering is broken with High or Ultra quality #97839

Open
SaracenOne opened this issue Oct 5, 2024 · 5 comments
Open

Comments

@SaracenOne
Copy link
Member

SaracenOne commented Oct 5, 2024

Tested versions

e2c6daf

System information

Godot v4.4.dev (65f3df5) - Windows 10.0.22631 - Single-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 32.0.15.6094) - AMD Ryzen 9 7950X 16-Core Processor (32 threads)

Issue description

Found another regression introduced in e2c6daf. It looks like all filtering for shadow maps no-longer works. Once again, only affects Forward+ and mobile renderers.
Post e2c6daf
godot windows editor dev x86_64_EXy1sxlQmB
Pre e2c6daf
godot windows editor dev x86_64_sSUadArpKU

Steps to reproduce

  • Create a directional light.
  • Enable a shadow.

Minimal reproduction project (MRP)

N/A

@DarioSamo
Copy link
Contributor

Was the filtering improved recently? Perhaps it was a conflict from when I rebased it. CC @clayjohn

Commenting to participate and look into it later.

@clayjohn
Copy link
Member

clayjohn commented Oct 5, 2024

There were some changes recently, but they only take effect when using TAA/FSR2.2. I don't think that is what we are seeing here

@DarioSamo DarioSamo self-assigned this Oct 17, 2024
@Calinou
Copy link
Member

Calinou commented Oct 17, 2024

I can't reproduce this in 4.4.dev 04692d8 (Linux, GeForce RTX 4090 with NVIDIA 560.35.03):

image

Lavapipe is also able to render it correctly:

image

TAA and FSR2.2 are disabled.

This can be tested in Truck Town which uses Forward+, but should render correctly when switched to Mobile too.

@DarioSamo
Copy link
Contributor

I'm unable to reproduce this as well. The only way I can get the shadow to show up like in OP's picture is to turn the Light's blur parameter to 0.

Could you upload an MRP with the issue? Perhaps there's a particular configuration setting we're missing.

@Calinou
Copy link
Member

Calinou commented Oct 26, 2024

I've finally found out the cause: it only breaks when the shadow filter quality is set to High or Ultra. This affects both Forward+ and Mobile.

This affects all light types.

Minimal reproduction project: test_shadow_filter.zip

@Calinou Calinou changed the title Shadowmap filtering regression. Directional shadow filtering is broken with High or Ultra quality Oct 26, 2024
@Calinou Calinou changed the title Directional shadow filtering is broken with High or Ultra quality Forward+/Mobile: Directional shadow filtering is broken with High or Ultra quality Oct 26, 2024
@Calinou Calinou changed the title Forward+/Mobile: Directional shadow filtering is broken with High or Ultra quality Forward+/Mobile: Shadow filtering is broken with High or Ultra quality Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

No branches or pull requests

4 participants