-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix built-in enum constant bindings #99424
Core: Fix built-in enum constant bindings #99424
Conversation
52a66ff
to
c202522
Compare
Note: I have not checked the GDExtension and C# binding generators, |
c202522
to
6206fd5
Compare
Here is the diff of
A GDExtension binding may technically need an update in the code generator (or an API dependent on it), if constants are missing -- but since the values are still there as enum variants, migration should be straightforward. And since both are passed as numbers to the actual GDExtension C API, binary compatibility shouldn't be broken. Which is the important part, because it means existing plugins will keep working with Godot 4.4 without recompilation. So from my side this is a welcome improvement! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the documentation side this is a big plus too
This shouldn't cause any issues with godot-cpp, since we have hand-written implementations of all the Like @Bromeon says above, this could theoretically cause issues with some GDExtension bindings' code generators, but we've made minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval for the impact on GDExtension only
6206fd5
to
d89f868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C# changes look good to me. I tested it and the generated bindings look as expected.
d89f868
to
03b05cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Thanks! |
get_method_list
provides invalid method info forget_primary_rotation_axis
#99531.Vector3.Axis
enum type in built-in methods and members #99341.