Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot4.4-dev4: Spaming loading messages if --verbose enabled. #99535

Open
MikeSchulze opened this issue Nov 22, 2024 · 2 comments · May be fixed by #99667
Open

Godot4.4-dev4: Spaming loading messages if --verbose enabled. #99535

MikeSchulze opened this issue Nov 22, 2024 · 2 comments · May be fixed by #99667

Comments

@MikeSchulze
Copy link

Tested versions

System information

all

Issue description

If verbose enabled, resource loading is now spamming loading messages.
Image

Image

I use ResourceLoader.load(<script_name>, "GDScript", ResourceLoader.CACHE_MODE_REUSE) to preload and force reuse scripts to mimimize loading times in my test framework. So I use explicit CACHE_MODE_REUSE.
But from the new log messages looks like the script is load again and again.

This spamming messages is filling my console when running my CI workflows now.
Godot4.4-dev5
Image
Godot4.3-stable
Image

Steps to reproduce

Use the script and attach it to a scene to reproduce.

extends Node2D


func _ready() -> void:
	load_test()
	get_tree().quit()


func load_test() -> void:

	for i in 10:
		ResourceLoader.load("res://test/example_script.gd", "GDScript", ResourceLoader.CACHE_MODE_REUSE)
  • run the scene on Godot4.4.dev4 and Godot4.4.dev5:
    output:
Loading resource: res://test/test.tscn
Loading resource: res://test/test.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
Loading resource: res://test/example_script.gd
--- Debugging process stopped ---

  • run on Godot4.3-dev3
Loading resource: res://test/test.tscn
Loading resource: res://test/test.gd
Loading resource: res://test/example_script.gd
--- Debugging process stopped ---

Minimal reproduction project (MRP)

n/a

@akien-mga
Copy link
Member

See #94920 - this brought back the behavior from 4.1 which some users were missing. Those prints hadn't been removed on purpose, so they were added back.

CC @RandomShaper

@MikeSchulze
Copy link
Author

But I use the flag CACHE_MODE_REUSE where indicates the resource should only load if not already cached.
So spamming the load message is not correct in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants